2018-12-13 20:26:33

by Fabrizio Castro

[permalink] [raw]
Subject: [PATCH] drm: rcar-du: lvds: add R8A774C0 support

The LVDS implementation on the RZ/G2E (a.k.a. R8A774C0) is very similar
to the one found on R-Car E3 (a.k.a. R8A77990), therefore add RZ/G2E
LVDS support to the LVDS encoder driver in a similar fashion to what
done for R-Car E3.

Signed-off-by: Fabrizio Castro <[email protected]>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 173d7ad..329dfca 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {

static const struct of_device_id rcar_lvds_of_table[] = {
{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
+ { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
{ .compatible = "renesas,r8a7793-lvds", .data = &rcar_lvds_gen2_info },
--
2.7.4



2018-12-13 21:40:01

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] drm: rcar-du: lvds: add R8A774C0 support

Hi Fabrizio,

Thank you for the patch.

On Thursday, 13 December 2018 22:23:36 EET Fabrizio Castro wrote:
> The LVDS implementation on the RZ/G2E (a.k.a. R8A774C0) is very similar
> to the one found on R-Car E3 (a.k.a. R8A77990), therefore add RZ/G2E
> LVDS support to the LVDS encoder driver in a similar fashion to what

s/what/what is/

> done for R-Car E3.
>
> Signed-off-by: Fabrizio Castro <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

and applied to my tree with the above fix.

> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 173d7ad..329dfca 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info
> rcar_lvds_r8a77995_info = {
>
> static const struct of_device_id rcar_lvds_of_table[] = {
> { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> + { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info
> }, { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info
> }, { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> { .compatible = "renesas,r8a7793-lvds", .data = &rcar_lvds_gen2_info },


--
Regards,

Laurent Pinchart




2018-12-14 08:13:20

by Fabrizio Castro

[permalink] [raw]
Subject: RE: [PATCH] drm: rcar-du: lvds: add R8A774C0 support

Hi Laurent,

> -----Original Message-----
> From: [email protected] <[email protected]> On Behalf Of Laurent Pinchart
> Sent: 13 December 2018 21:38
> To: Fabrizio Castro <[email protected]>
> Cc: David Airlie <[email protected]>; Kieran Bingham <[email protected]>; [email protected];
> [email protected]; [email protected]; Simon Horman <[email protected]>; Geert Uytterhoeven
> <[email protected]>; Chris Paterson <[email protected]>; Biju Das <[email protected]>
> Subject: Re: [PATCH] drm: rcar-du: lvds: add R8A774C0 support
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Thursday, 13 December 2018 22:23:36 EET Fabrizio Castro wrote:
> > The LVDS implementation on the RZ/G2E (a.k.a. R8A774C0) is very similar
> > to the one found on R-Car E3 (a.k.a. R8A77990), therefore add RZ/G2E
> > LVDS support to the LVDS encoder driver in a similar fashion to what
>
> s/what/what is/
>
> > done for R-Car E3.
> >
> > Signed-off-by: Fabrizio Castro <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>
> and applied to my tree with the above fix.

Thank you for fixing.

Fab

>
> > ---
> > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 173d7ad..329dfca 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> > @@ -785,6 +785,7 @@ static const struct rcar_lvds_device_info
> > rcar_lvds_r8a77995_info = {
> >
> > static const struct of_device_id rcar_lvds_of_table[] = {
> > { .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
> > +{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info
> > }, { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info
> > }, { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> > { .compatible = "renesas,r8a7793-lvds", .data = &rcar_lvds_gen2_info },
>
>
> --
> Regards,
>
> Laurent Pinchart
>
>



[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

2018-12-17 14:03:54

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] drm: rcar-du: lvds: add R8A774C0 support

On Thu, Dec 13, 2018 at 08:23:36PM +0000, Fabrizio Castro wrote:
> The LVDS implementation on the RZ/G2E (a.k.a. R8A774C0) is very similar
> to the one found on R-Car E3 (a.k.a. R8A77990), therefore add RZ/G2E
> LVDS support to the LVDS encoder driver in a similar fashion to what
> done for R-Car E3.
>
> Signed-off-by: Fabrizio Castro <[email protected]>

Reviewed-by: Simon Horman <[email protected]>