2018-12-18 13:41:26

by Shayenne Moura

Subject: [PATCH 4/7] drm: i915: Delete base.id prints

This patch removes base.id prints from drm_display_mode
objects in i915 files. It removes dependency from drm_mode_object.

Signed-off-by: Shayenne Moura <[email protected]>
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7f455bca528e..61dd7bb3fa85 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
for (i = 0; i < tabs; i++)
seq_putc(m, '\t');

- seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
- mode->base.id, mode->name,
+ seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
+ mode->name,
mode->vrefresh, mode->clock,
mode->hdisplay, mode->hsync_start,
mode->hsync_end, mode->htotal,
--
2.17.1

2018-12-19 15:20:58

by Jani Nikula

Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints

On Tue, 18 Dec 2018, Shayenne Moura <[email protected]> wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.

As said, this could expand on the *why*. With that fixed,

Reviewed-by: Jani Nikula <[email protected]>

as well as acked for merging via drm-misc.

>
> Signed-off-by: Shayenne Moura <[email protected]>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,

--
Jani Nikula, Intel Open Source Graphics Center

2018-12-19 16:33:44

by Daniel Vetter

Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints

On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura <[email protected]>

Again I think better to switch to DRM_MODE_FMT/ARG.
-Daniel

> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2018-12-19 19:16:56

by Daniel Vetter

Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints

On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura
<[email protected]> wrote:
>
> On 12/19, Daniel Vetter wrote:
> > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > > This patch removes base.id prints from drm_display_mode
> > > objects in i915 files. It removes dependency from drm_mode_object.
> > >
> > > Signed-off-by: Shayenne Moura <[email protected]>
> >
> > Again I think better to switch to DRM_MODE_FMT/ARG.
> > -Daniel
> >
>
> This one has a different print style. Is it okay to change to DRM_MODE_FMT?

Yeah, standardizing sounds good, just mention in the commit message if
something has changed. This is all debug information, so no issue if
we change the output format slightly.
-Daniel

>
> Best,
> Shayenne
> > > ---
> > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 7f455bca528e..61dd7bb3fa85 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > > for (i = 0; i < tabs; i++)
> > > seq_putc(m, '\t');
> > >
> > > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > - mode->base.id, mode->name,
> > > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > + mode->name,
> > > mode->vrefresh, mode->clock,
> > > mode->hdisplay, mode->hsync_start,
> > > mode->hsync_end, mode->htotal,
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > [email protected]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

2018-12-19 20:42:06

by Shayenne Moura

Subject: Re: [PATCH 4/7] drm: i915: Delete base.id prints

On 12/19, Daniel Vetter wrote:
> On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > This patch removes base.id prints from drm_display_mode
> > objects in i915 files. It removes dependency from drm_mode_object.
> >
> > Signed-off-by: Shayenne Moura <[email protected]>
>
> Again I think better to switch to DRM_MODE_FMT/ARG.
> -Daniel
>

This one has a different print style. Is it okay to change to DRM_MODE_FMT?

Best,
Shayenne
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 7f455bca528e..61dd7bb3fa85 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > for (i = 0; i < tabs; i++)
> > seq_putc(m, '\t');
> >
> > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > - mode->base.id, mode->name,
> > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > + mode->name,
> > mode->vrefresh, mode->clock,
> > mode->hdisplay, mode->hsync_start,
> > mode->hsync_end, mode->htotal,
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch