2018-12-23 11:30:41

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH] net/mlx5e: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
CC: Gavi Teitz <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 340ae71f9dd421227a58c14a909b63033745dca4
commit: 4c8fb2986d44c5a75949a88ac61deec0ed50a542 [11213/11734] net/mlx5e: Increase VF representors' SQ size to 128

en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -1336,7 +1336,7 @@ static void mlx5e_build_rep_params(struc
if (rep->vport == FDB_UPLINK_VPORT)
params->log_sq_size = MLX5E_PARAMS_DEFAULT_LOG_SQ_SIZE;
else
- params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;;
+ params->log_sq_size = MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;

/* RQ */
mlx5e_build_rq_params(mdev, params);


2018-12-23 16:40:07

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

On Sat, Dec 22, 2018 at 08:02:16PM +0800, kbuild test robot wrote:
> From: kbuild test robot <[email protected]>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>
> ---

Dave,

Can you please apply this small fix?

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

Attachments:
(No filename) (603.00 B)
 signature.asc (817.00 B)
 Download all attachments

2018-12-24 18:02:31

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

From: Leon Romanovsky <[email protected]>
Date: Sun, 23 Dec 2018 09:06:13 +0200

> Can you please apply this small fix?

Sure, I (eventually) will. I'm just trying to figure out a few procedural
issues with handling the early net-next pull request before I start tossing
more changes on top.

Thanks!

2018-12-24 22:21:48

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>
Date: Sat, 22 Dec 2018 20:02:16 +0800

> From: kbuild test robot <[email protected]>
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 4c8fb2986d44 ("net/mlx5e: Increase VF representors' SQ size to 128")
> CC: Gavi Teitz <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>

Applied.