2018-12-23 16:42:17

by Katsuhiro Suzuki

Subject: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64

The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1 and ACODEC core.

This patch adds sound node for analog audio for Rock64.

Signed-off-by: Katsuhiro Suzuki <[email protected]>
---

This patch depends on the following ACODEC node patch. If ACODEC
patch is not good to you, please drop this patch too.
https://lkml.org/lkml/2018/12/23/53

.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 27 ++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index bd937d68ca3b..0a71e1287a1b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -66,7 +66,8 @@
sound {
compatible = "audio-graph-card";
label = "rockchip,rk3328";
- dais = <&spdif_p0>;
+ dais = <&i2s1_p0
+ &spdif_p0>;
};

spdif-dit {
@@ -81,6 +82,17 @@
};
};

+&codec {
+ status = "okay";
+ #sound-dai-cells = <0>;
+
+ port@0 {
+ codec_p0_0: endpoint {
+ remote-endpoint = <&i2s1_p0_0>;
+ };
+ };
+};
+
&cpu0 {
cpu-supply = <&vdd_arm>;
};
@@ -243,6 +255,19 @@
};
};

+&i2s1 {
+ status = "okay";
+ #sound-dai-cells = <0>;
+
+ i2s1_p0: port {
+ i2s1_p0_0: endpoint {
+ dai-format = "i2s";
+ mclk-fs = <256>;
+ remote-endpoint = <&codec_p0_0>;
+ };
+ };
+};
+
&io_domains {
status = "okay";

--
2.19.2

2018-12-24 07:19:32

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64

Hi,

Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
> The Rock64 boards has analog audio jack on it. RK3328 can output
> analog audio signal using I2S1 and ACODEC core.
>
> This patch adds sound node for analog audio for Rock64.
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>

I've put a patch collecting the sound-dai-cells in rk3328.dtsi
before this one, dropped the sound-dai-cells from here and
applied the patch for 4.22.

Thanks
Heiko

2018-12-24 13:01:33

by Katsuhiro Suzuki

Subject: Re: [PATCH] arm64: dts: rockchip: enable analog audio node for rock64

Hello Heiko,

I understand. Thanks a lot!

Best Regards,
Katsuhiro Suzuki

On 2018/12/24 16:16, Heiko Stuebner wrote:
> Hi,
>
> Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
>> The Rock64 boards has analog audio jack on it. RK3328 can output
>> analog audio signal using I2S1 and ACODEC core.
>>
>> This patch adds sound node for analog audio for Rock64.
>>
>> Signed-off-by: Katsuhiro Suzuki <[email protected]>
>
> I've put a patch collecting the sound-dai-cells in rk3328.dtsi
> before this one, dropped the sound-dai-cells from here and
> applied the patch for 4.22.
>
> Thanks
> Heiko
>
>
>