2019-01-09 17:59:46

by Brajeswar Ghosh

Subject: [PATCH] staging/android/vsoc: Remove duplicate header

Remove linux/mutex.h.h which is included more than once

Signed-off-by: Brajeswar Ghosh <[email protected]>
---
drivers/staging/android/vsoc.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c
index 22571abcaa4e..8a75bd27c413 100644
--- a/drivers/staging/android/vsoc.c
+++ b/drivers/staging/android/vsoc.c
@@ -29,7 +29,6 @@
#include <linux/syscalls.h>
#include <linux/uaccess.h>
#include <linux/interrupt.h>
-#include <linux/mutex.h>
#include <linux/cdev.h>
#include <linux/file.h>
#include "uapi/vsoc_shm.h"
--
2.17.1

2019-01-15 06:37:06

by Souptick Joarder

Subject: Re: [PATCH] staging/android/vsoc: Remove duplicate header

On Wed, Jan 9, 2019 at 8:56 PM Brajeswar Ghosh
<[email protected]> wrote:
>
> Remove linux/mutex.h.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>

Acked-by: Souptick Joarder <[email protected]>

> ---
> drivers/staging/android/vsoc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c
> index 22571abcaa4e..8a75bd27c413 100644
> --- a/drivers/staging/android/vsoc.c
> +++ b/drivers/staging/android/vsoc.c
> @@ -29,7 +29,6 @@
> #include <linux/syscalls.h>
> #include <linux/uaccess.h>
> #include <linux/interrupt.h>
> -#include <linux/mutex.h>
> #include <linux/cdev.h>
> #include <linux/file.h>
> #include "uapi/vsoc_shm.h"
> --
> 2.17.1
>

2019-01-15 16:25:45

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging/android/vsoc: Remove duplicate header

On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote:
> Remove linux/mutex.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>
> Acked-by: Souptick Joarder <[email protected]>
> ---
> drivers/staging/android/vsoc.c | 1 -
> 1 file changed, 1 deletion(-)

This does not apply as it is already in the tree, are you sure you are
working against the latest release?

thanks,

greg k-h

2019-01-15 17:28:15

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging/android/vsoc: Remove duplicate header

On Tue, Jan 15, 2019 at 03:59:42PM +0100, Greg KH wrote:
> On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote:
> > Remove linux/mutex.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <[email protected]>
> > Acked-by: Souptick Joarder <[email protected]>
> > ---
> > drivers/staging/android/vsoc.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> This does not apply as it is already in the tree, are you sure you are
> working against the latest release?

Ugh, my fault, nevermind...

2019-01-15 17:36:33

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging/android/vsoc: Remove duplicate header

On Wed, Jan 09, 2019 at 08:55:59PM +0530, Brajeswar Ghosh wrote:
> Remove linux/mutex.h.h which is included more than once

I think you have one too many ".h" in that line :)

I'll go fix it up...