2018-12-23 16:43:39

by Abel Vesa

Subject: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

Since this is going to be used on more SoCs than just i.MX8MQ,
make the dependency here more generic.

Signed-off-by: Abel Vesa <[email protected]>
Reviewed-by: Dong Aisheng <[email protected]>
---
Changes since v1:
* removed the SOC_IMX7D since it's included by ARCH_MXC
as suggested by Dong Aisheng.

drivers/soc/imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 2112d18..d80f899 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,7 +2,7 @@ menu "i.MX SoC drivers"

config IMX_GPCV2_PM_DOMAINS
bool "i.MX GPCv2 PM domains"
- depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
+ depends on ARCH_MXC || (COMPILE_TEST && OF)
depends on PM
select PM_GENERIC_DOMAINS
default y if SOC_IMX7D
--
2.7.4

2019-01-12 03:10:33

by Shawn Guo

Subject: Re: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

On Sun, Dec 23, 2018 at 01:20:34PM +0000, Abel Vesa wrote:
> Since this is going to be used on more SoCs than just i.MX8MQ,
> make the dependency here more generic.
>
> Signed-off-by: Abel Vesa <[email protected]>
> Reviewed-by: Dong Aisheng <[email protected]>
> ---
> Changes since v1:
> * removed the SOC_IMX7D since it's included by ARCH_MXC

This should really be mentioned in the commit log.

Shawn

> as suggested by Dong Aisheng.
>
> drivers/soc/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> index 2112d18..d80f899 100644
> --- a/drivers/soc/imx/Kconfig
> +++ b/drivers/soc/imx/Kconfig
> @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
>
> config IMX_GPCV2_PM_DOMAINS
> bool "i.MX GPCv2 PM domains"
> - depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> + depends on ARCH_MXC || (COMPILE_TEST && OF)
> depends on PM
> select PM_GENERIC_DOMAINS
> default y if SOC_IMX7D
> --
> 2.7.4
>

2019-01-12 03:17:07

by Aisheng Dong

Subject: RE: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

> From: Shawn Guo [mailto:[email protected]]
> Sent: Saturday, January 12, 2019 11:09 AM
> On Sun, Dec 23, 2018 at 01:20:34PM +0000, Abel Vesa wrote:
> > Since this is going to be used on more SoCs than just i.MX8MQ, make
> > the dependency here more generic.
> >
> > Signed-off-by: Abel Vesa <[email protected]>
> > Reviewed-by: Dong Aisheng <[email protected]>
> > ---
> > Changes since v1:
> > * removed the SOC_IMX7D since it's included by ARCH_MXC
>
> This should really be mentioned in the commit log.
>

Yes, you're right. We should put it in commit log.

Abel,
Would you resend with this updated?

Regards
Dong Aisheng

> Shawn
>
> > as suggested by Dong Aisheng.
> >
> > drivers/soc/imx/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > 2112d18..d80f899 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
> >
> > config IMX_GPCV2_PM_DOMAINS
> > bool "i.MX GPCv2 PM domains"
> > - depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> > + depends on ARCH_MXC || (COMPILE_TEST && OF)
> > depends on PM
> > select PM_GENERIC_DOMAINS
> > default y if SOC_IMX7D
> > --
> > 2.7.4
> >