2019-01-14 17:02:02

by Brajeswar Ghosh

[permalink] [raw]
Subject: [PATCH] samples/mic/mpssd: Remove duplicate header

Remove duplicate headers which are included more than once

Signed-off-by: Brajeswar Ghosh <[email protected]>
---
samples/mic/mpssd/mpssd.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/samples/mic/mpssd/mpssd.h b/samples/mic/mpssd/mpssd.h
index 8bd64944aacc..82d3b519f0e7 100644
--- a/samples/mic/mpssd/mpssd.h
+++ b/samples/mic/mpssd/mpssd.h
@@ -37,21 +37,18 @@
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/stat.h>
-#include <sys/types.h>
#include <sys/mman.h>
#include <sys/utsname.h>
#include <sys/wait.h>
#include <netinet/in.h>
#include <arpa/inet.h>
#include <netdb.h>
-#include <pthread.h>
#include <signal.h>
#include <limits.h>
#include <syslog.h>
#include <getopt.h>
#include <net/if.h>
#include <linux/if_tun.h>
-#include <linux/if_tun.h>
#include <linux/virtio_ids.h>

#define MICSYSFSDIR "/sys/class/mic"
--
2.17.1



2019-01-30 14:36:16

by Brajeswar Ghosh

[permalink] [raw]
Subject: Re: [PATCH] samples/mic/mpssd: Remove duplicate header

On Mon, Jan 14, 2019 at 10:30 PM Brajeswar Ghosh
<[email protected]> wrote:
>
> Remove duplicate headers which are included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>

Any comment on this patch?

> ---
> samples/mic/mpssd/mpssd.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/samples/mic/mpssd/mpssd.h b/samples/mic/mpssd/mpssd.h
> index 8bd64944aacc..82d3b519f0e7 100644
> --- a/samples/mic/mpssd/mpssd.h
> +++ b/samples/mic/mpssd/mpssd.h
> @@ -37,21 +37,18 @@
> #include <sys/types.h>
> #include <sys/socket.h>
> #include <sys/stat.h>
> -#include <sys/types.h>
> #include <sys/mman.h>
> #include <sys/utsname.h>
> #include <sys/wait.h>
> #include <netinet/in.h>
> #include <arpa/inet.h>
> #include <netdb.h>
> -#include <pthread.h>
> #include <signal.h>
> #include <limits.h>
> #include <syslog.h>
> #include <getopt.h>
> #include <net/if.h>
> #include <linux/if_tun.h>
> -#include <linux/if_tun.h>
> #include <linux/virtio_ids.h>
>
> #define MICSYSFSDIR "/sys/class/mic"
> --
> 2.17.1
>