2019-01-17 12:42:32

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH v3 0/2] Support for eMMC in AM65x-evm

The following patches add eMMC support on TI's AM65x-evm.

v3:
1. Fixed patch titles to only include eMMC
2. Added dma-coherent to the sdhci0 node.

v2:
1. The SD card node is under debug for some usecases.
Only upstreaming eMMC support for now.
2. Rebased to latest mainline.
3. Removed status = "disabled" from dtsi patch
4. Fixed node name to not include '_'s

Faiz Abbas (2):
arm64: dts: ti: k3-am654: Add Support for eMMC host controller
arm64: dts: ti: k3-am654-base-board: Add eMMC Support

arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 +++++++++++
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
2 files changed, 39 insertions(+)

--
2.19.2



2019-01-17 09:51:21

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH v3 2/2] arm64: dts: ti: k3-am654-base-board: Add eMMC Support

On the am654x-evm, sdhci0 node is connected to an eMMC. Add node and
pinmux for the same.

Signed-off-by: Faiz Abbas <[email protected]>
Acked-by: Nishanth Menon <[email protected]>
---
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index e41fc3a5987b..11e9a2a43dfc 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -69,6 +69,23 @@
AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */
>;
};
+
+ main_mmc0_pins_default: main-mmc0-pins-default {
+ pinctrl-single,pins = <
+ AM65X_IOPAD(0x01a8, PIN_INPUT_PULLDOWN, 0) /* (B25) MMC0_CLK */
+ AM65X_IOPAD(0x01ac, PIN_INPUT_PULLUP, 0) /* (B27) MMC0_CMD */
+ AM65X_IOPAD(0x01a4, PIN_INPUT_PULLUP, 0) /* (A26) MMC0_DAT0 */
+ AM65X_IOPAD(0x01a0, PIN_INPUT_PULLUP, 0) /* (E25) MMC0_DAT1 */
+ AM65X_IOPAD(0x019c, PIN_INPUT_PULLUP, 0) /* (C26) MMC0_DAT2 */
+ AM65X_IOPAD(0x0198, PIN_INPUT_PULLUP, 0) /* (A25) MMC0_DAT3 */
+ AM65X_IOPAD(0x0194, PIN_INPUT_PULLUP, 0) /* (E24) MMC0_DAT4 */
+ AM65X_IOPAD(0x0190, PIN_INPUT_PULLUP, 0) /* (A24) MMC0_DAT5 */
+ AM65X_IOPAD(0x018c, PIN_INPUT_PULLUP, 0) /* (B26) MMC0_DAT6 */
+ AM65X_IOPAD(0x0188, PIN_INPUT_PULLUP, 0) /* (D25) MMC0_DAT7 */
+ AM65X_IOPAD(0x01b4, PIN_INPUT_PULLUP, 0) /* (A23) MMC0_SDCD */
+ AM65X_IOPAD(0x01b0, PIN_INPUT, 0) /* (C25) MMC0_DS */
+ >;
+ };
};

&main_pmx1 {
@@ -163,3 +180,11 @@
#size-cells= <1>;
};
};
+
+&sdhci0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_mmc0_pins_default>;
+ bus-width = <8>;
+ non-removable;
+ ti,driver-strength-ohm = <50>;
+};
--
2.19.2


2019-01-17 09:52:02

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH v3 1/2] arm64: dts: ti: k3-am654: Add Support for eMMC host controller

Add support for the Secure Digital Host Controller Interface (SDHCI)
present on TI's AM654 SOCs. It is compatible with eMMC5.1 Host
Specifications.

Enable only upto HS200 speed mode.

Signed-off-by: Faiz Abbas <[email protected]>
Acked-by: Nishanth Menon <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 272cf8fc8d30..9338315b0ca9 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -191,4 +191,18 @@
#address-cells = <1>;
#size-cells = <0>;
};
+
+ sdhci0: sdhci@4f80000 {
+ compatible = "ti,am654-sdhci-5.1";
+ reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
+ power-domains = <&k3_pds 47>;
+ clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
+ clock-names = "clk_ahb", "clk_xin";
+ interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ ti,otap-del-sel = <0x2>;
+ ti,trm-icp = <0x8>;
+ dma-coherent;
+ };
};
--
2.19.2


2019-01-24 08:11:26

by Faiz Abbas

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Support for eMMC in AM65x-evm

Hi,

On 17/01/19 3:14 PM, Faiz Abbas wrote:
> The following patches add eMMC support on TI's AM65x-evm.
>
> v3:
> 1. Fixed patch titles to only include eMMC
> 2. Added dma-coherent to the sdhci0 node.
>
> v2:
> 1. The SD card node is under debug for some usecases.
> Only upstreaming eMMC support for now.
> 2. Rebased to latest mainline.
> 3. Removed status = "disabled" from dtsi patch
> 4. Fixed node name to not include '_'s
>
> Faiz Abbas (2):
> arm64: dts: ti: k3-am654: Add Support for eMMC host controller
> arm64: dts: ti: k3-am654-base-board: Add eMMC Support
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 +++++++++++
> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
> 2 files changed, 39 insertions(+)
>

Gentle ping.

Thanks,
Faiz

2019-01-24 12:42:19

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Support for eMMC in AM65x-evm

On 13:43-20190124, Faiz Abbas wrote:
> Hi,
>
> On 17/01/19 3:14 PM, Faiz Abbas wrote:
> > The following patches add eMMC support on TI's AM65x-evm.
> >
> > v3:
> > 1. Fixed patch titles to only include eMMC
> > 2. Added dma-coherent to the sdhci0 node.
> >
> > v2:
> > 1. The SD card node is under debug for some usecases.
> > Only upstreaming eMMC support for now.
> > 2. Rebased to latest mainline.
> > 3. Removed status = "disabled" from dtsi patch
> > 4. Fixed node name to not include '_'s
> >
> > Faiz Abbas (2):
> > arm64: dts: ti: k3-am654: Add Support for eMMC host controller
> > arm64: dts: ti: k3-am654-base-board: Add eMMC Support
> >
> > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 +++++++++++
> > .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
> > 2 files changed, 39 insertions(+)
> >
>
> Gentle ping.


OK With me. Tero: are you publishing a next branch? could you
pick this up please?

--
Regards,
Nishanth Menon

2019-01-24 19:46:59

by Tero Kristo

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Support for eMMC in AM65x-evm

On 24/01/2019 14:40, Nishanth Menon wrote:
> On 13:43-20190124, Faiz Abbas wrote:
>> Hi,
>>
>> On 17/01/19 3:14 PM, Faiz Abbas wrote:
>>> The following patches add eMMC support on TI's AM65x-evm.
>>>
>>> v3:
>>> 1. Fixed patch titles to only include eMMC
>>> 2. Added dma-coherent to the sdhci0 node.
>>>
>>> v2:
>>> 1. The SD card node is under debug for some usecases.
>>> Only upstreaming eMMC support for now.
>>> 2. Rebased to latest mainline.
>>> 3. Removed status = "disabled" from dtsi patch
>>> 4. Fixed node name to not include '_'s
>>>
>>> Faiz Abbas (2):
>>> arm64: dts: ti: k3-am654: Add Support for eMMC host controller
>>> arm64: dts: ti: k3-am654-base-board: Add eMMC Support
>>>
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 +++++++++++
>>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
>>> 2 files changed, 39 insertions(+)
>>>
>>
>> Gentle ping.
>
>
> OK With me. Tero: are you publishing a next branch? could you
> pick this up please?
>

Yeah, series looks fine so I'll queue it up for 5.1.

I am not currently publishing -next branch, but I can start tracking one.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2019-01-24 19:50:38

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Support for eMMC in AM65x-evm

* Tero Kristo <[email protected]> [190124 19:46]:
> I am not currently publishing -next branch, but I can start tracking one.

Yes please do as the patches should be sitting in
Linux next for at least two weeks before merging.
And there can be often delays of multiple days with
getting patches merged to armsoc next branch.

Regards,

Tony

2019-02-01 09:02:28

by Tero Kristo

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Support for eMMC in AM65x-evm

On 24/01/2019 14:40, Nishanth Menon wrote:
> On 13:43-20190124, Faiz Abbas wrote:
>> Hi,
>>
>> On 17/01/19 3:14 PM, Faiz Abbas wrote:
>>> The following patches add eMMC support on TI's AM65x-evm.
>>>
>>> v3:
>>> 1. Fixed patch titles to only include eMMC
>>> 2. Added dma-coherent to the sdhci0 node.
>>>
>>> v2:
>>> 1. The SD card node is under debug for some usecases.
>>> Only upstreaming eMMC support for now.
>>> 2. Rebased to latest mainline.
>>> 3. Removed status = "disabled" from dtsi patch
>>> 4. Fixed node name to not include '_'s
>>>
>>> Faiz Abbas (2):
>>> arm64: dts: ti: k3-am654: Add Support for eMMC host controller
>>> arm64: dts: ti: k3-am654-base-board: Add eMMC Support
>>>
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 14 +++++++++++
>>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 25 +++++++++++++++++++
>>> 2 files changed, 39 insertions(+)
>>>
>>
>> Gentle ping.
>
>
> OK With me. Tero: are you publishing a next branch? could you
> pick this up please?
>

Ok, queued up for 5.1.

I also pushed an am654-next branch to git.kernel.org. This is not
tracked in linux-next yet though, I am not quite sure if anybody is
doing any am654 testing with linux-next, and I only push DT patches via
this branch anyway which are kind of special.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki