2019-01-18 03:34:28

by Yue Haibing

[permalink] [raw]
Subject: [PATCH] wireless: remove unneeded semicolon

remove unneeded semicolon

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
drivers/net/wireless/ath/ath6kl/init.c | 2 +-
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
drivers/net/wireless/ray_cs.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 6 +++---
5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index 2034ccc..021eb30 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -1986,7 +1986,7 @@ static inline const char *ath10k_wmi_phymode_str(enum wmi_phy_mode mode)
/* no default handler to allow compiler to check that the
* enum is fully handled
*/
- };
+ }

return "<unknown>";
}
diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
index 54132af..aa1c71a 100644
--- a/drivers/net/wireless/ath/ath6kl/init.c
+++ b/drivers/net/wireless/ath/ath6kl/init.c
@@ -1140,7 +1140,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)

len -= ie_len;
data += ie_len;
- };
+ }

ret = 0;
out:
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index d64bf23..ec12986 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -315,7 +315,7 @@ static int brcmf_sdiod_skbuff_read(struct brcmf_sdio_dev *sdiodev,
/* bail out as things are really fishy here */
WARN(1, "invalid sdio function number: %d\n", func->num);
err = -ENOMEDIUM;
- };
+ }

if (err == -ENOMEDIUM)
brcmf_sdiod_change_state(sdiodev, BRCMF_SDIOD_NOMEDIUM);
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index 33ad875..b58bb7b 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2211,7 +2211,7 @@ static void rx_data(struct net_device *dev, struct rcs __iomem *prcs,
untranslate(local, skb, total_len);
}
} else { /* sniffer mode, so just pass whole packet */
- };
+ }

/************************/
/* Now pick up the rest of the fragments if any */
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
index 1263b12..11f94b1 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
@@ -332,7 +332,7 @@ static void _rtl8723be_phy_set_txpower_by_rate_base(struct ieee80211_hw *hw,
"Invalid RateSection %d in Band 2.4G, Rf Path %d, %dTx in PHY_SetTxPowerByRateBase()\n",
rate_section, path, txnum);
break;
- };
+ }
} else {
RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
"Invalid Band %d in PHY_SetTxPowerByRateBase()\n",
@@ -374,7 +374,7 @@ static u8 _rtl8723be_phy_get_txpower_by_rate_base(struct ieee80211_hw *hw,
"Invalid RateSection %d in Band 2.4G, Rf Path %d, %dTx in PHY_GetTxPowerByRateBase()\n",
rate_section, path, txnum);
break;
- };
+ }
} else {
RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,
"Invalid Band %d in PHY_GetTxPowerByRateBase()\n",
@@ -694,7 +694,7 @@ static u8 _rtl8723be_get_rate_section_index(u32 regaddr)
else if (regaddr >= 0xE20 && regaddr <= 0xE4C)
index = (u8)((regaddr - 0xE20) / 4);
break;
- };
+ }
return index;
}

--
2.7.0




2019-01-18 04:00:25

by Ping-Ke Shih

[permalink] [raw]
Subject: Re: [PATCH] wireless: remove unneeded semicolon

On Fri, 2019-01-18 at 11:32 +0800, YueHaibing wrote:
> remove unneeded semicolon
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
>  drivers/net/wireless/ath/ath10k/wmi.h                     | 2 +-
>  drivers/net/wireless/ath/ath6kl/init.c                    | 2 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
>  drivers/net/wireless/ray_cs.c                             | 2 +-
>  drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c      | 6 +++---

For rtlwifi driver,
Acked-by: Ping-Ke Shih <[email protected]>

2019-01-18 05:50:08

by Steve deRosier

[permalink] [raw]
Subject: Re: [PATCH] wireless: remove unneeded semicolon

On Thu, Jan 17, 2019 at 7:33 PM YueHaibing <[email protected]> wrote:
>
> remove unneeded semicolon
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
> drivers/net/wireless/ath/ath6kl/init.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
> drivers/net/wireless/ray_cs.c | 2 +-
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 6 +++---
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
...
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index 54132af..aa1c71a 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1140,7 +1140,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
>
> len -= ie_len;
> data += ie_len;
> - };
> + }
>
> ret = 0;
> out:

For ath6kl

Acked-by: Steve deRosier <[email protected]>

2019-01-18 09:48:01

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] wireless: remove unneeded semicolon

On 1/18/2019 4:32 AM, YueHaibing wrote:
> remove unneeded semicolon

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-

2019-02-01 12:59:48

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wireless: remove unneeded semicolon

YueHaibing <[email protected]> wrote:

> remove unneeded semicolon
>
> Signed-off-by: YueHaibing <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>
> Acked-by: Steve deRosier <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

999eb686aa90 wireless: remove unneeded semicolon

--
https://patchwork.kernel.org/patch/10769393/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches