2019-01-18 21:42:39

by Gustavo A. R. Silva

Subject: [PATCH] drm/komeda: Remove unused variable

Remove unused variable *pdev* in komeda_parse_dt():

drivers/gpu/drm/arm/display/komeda//komeda_dev.c: In function ‘komeda_parse_dt’:
drivers/gpu/drm/arm/display/komeda//komeda_dev.c:52:26: warning: unused variable ‘pdev’ [-Wunused-variable]
struct platform_device *pdev = to_platform_device(dev);
^~~~

Fixes: 7e8d4fcf8daf ("drm: arm/komeda: Remove IRQ parsing from initial series")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 16f4e72abc1a..0fe6954fbbf4 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -49,7 +49,6 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)

static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
{
- struct platform_device *pdev = to_platform_device(dev);
struct device_node *child, *np = dev->of_node;
struct clk *clk;
int ret;
--
2.20.1

2019-01-21 08:42:45

by James Qian Wang

Subject: Re: drm/komeda: Remove unused variable

Hi Gustavo:

Thank you for helping fix this problem


On Fri, Jan 18, 2019 at 03:40:18PM -0600, Gustavo A. R. Silva wrote:
> Remove unused variable *pdev* in komeda_parse_dt():
>
> drivers/gpu/drm/arm/display/komeda//komeda_dev.c: In function ‘komeda_parse_dt’:
> drivers/gpu/drm/arm/display/komeda//komeda_dev.c:52:26: warning: unused variable ‘pdev’ [-Wunused-variable]
> struct platform_device *pdev = to_platform_device(dev);
> ^~~~
>
> Fixes: 7e8d4fcf8daf ("drm: arm/komeda: Remove IRQ parsing from initial series")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 16f4e72abc1a..0fe6954fbbf4 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -49,7 +49,6 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
>
> static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
> {
> -struct platform_device *pdev = to_platform_device(dev);
> struct device_node *child, *np = dev->of_node;
> struct clk *clk;
> int ret;
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.