Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
depends on BACKLIGHT_LCD_SUPPORT.
Copy this dependency into ACPI_CMPC.
Signed-off-by: Sinan Kaya <[email protected]>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 5e2109c54c7c..b84c2c5b6684 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -904,7 +904,7 @@ config TOSHIBA_WMI
config ACPI_CMPC
tristate "CMPC Laptop Extras"
- depends on ACPI && INPUT
+ depends on ACPI && INPUT && BACKLIGHT_LCD_SUPPORT
depends on RFKILL || RFKILL=n
select BACKLIGHT_CLASS_DEVICE
help
--
2.19.0
Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
SAMSUNG_Q10 selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
depends on BACKLIGHT_LCD_SUPPORT.
Copy this dependency into SAMSUNG_Q10.
Signed-off-by: Sinan Kaya <[email protected]>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b84c2c5b6684..129e37c296a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1127,7 +1127,7 @@ config INTEL_OAKTRAIL
config SAMSUNG_Q10
tristate "Samsung Q10 Extras"
- depends on ACPI
+ depends on ACPI && BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
---help---
This driver provides support for backlight control on Samsung Q10
--
2.19.0
On 1/21/2019 5:46 PM, Sinan Kaya wrote:
> ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
> depends on BACKLIGHT_LCD_SUPPORT.
This should have been:
ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_LCD_SUPPORT.
On Monday, January 21, 2019 11:46:43 PM CET Sinan Kaya wrote:
> Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
>
> ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
> depends on BACKLIGHT_LCD_SUPPORT.
>
> Copy this dependency into ACPI_CMPC.
>
> Signed-off-by: Sinan Kaya <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 5e2109c54c7c..b84c2c5b6684 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -904,7 +904,7 @@ config TOSHIBA_WMI
>
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> - depends on ACPI && INPUT
> + depends on ACPI && INPUT && BACKLIGHT_LCD_SUPPORT
> depends on RFKILL || RFKILL=n
> select BACKLIGHT_CLASS_DEVICE
> help
>
Andy/Darren, these two seem to be for you, but I can take them too as
related to ACPI tagentially, so please let me know.
On 1/24/2019 5:52 AM, Rafael J. Wysocki wrote:
> Andy/Darren, these two seem to be for you, but I can take them too as
> related to ACPI tagentially, so please let me know.
I'll post V2 to fix a "fat-finger" in summary. I was hoping to receive a
feedback until now.
I'll get the V2 out.
On Thu, Jan 24, 2019 at 12:54 PM Rafael J. Wysocki <[email protected]> wrote:
>
> On Monday, January 21, 2019 11:46:43 PM CET Sinan Kaya wrote:
> > Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> > warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
> >
> > ACPI_CMPC selects BACKLIGHT_LCD_SUPPORT but BACKLIGHT_LCD_SUPPORT
> > depends on BACKLIGHT_LCD_SUPPORT.
> >
> > Copy this dependency into ACPI_CMPC.
> Andy/Darren, these two seem to be for you, but I can take them too as
> related to ACPI tagentially, so please let me know.
Answered to v2. One comment still to be addressed, otherwise feel free
to take them.
--
With Best Regards,
Andy Shevchenko