2019-01-09 11:57:28

by wangbo

[permalink] [raw]
Subject: [PATCH] uio:remove unneeded variable ret

In uio_dmem_genirq_open the variable ret is unneededw,remove it now.

Signed-off-by: wangbo <[email protected]>
---
drivers/uio/uio_dmem_genirq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 003bada..2be7569 100644
--- a/drivers/uio/uio_dmem_genirq.c
+++ b/drivers/uio/uio_dmem_genirq.c
@@ -47,7 +47,6 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
{
struct uio_dmem_genirq_platdata *priv = info->priv;
struct uio_mem *uiomem;
- int ret = 0;
int dmem_region = priv->dmem_region_start;

uiomem = &priv->uioinfo->mem[priv->dmem_region_start];
@@ -71,7 +70,7 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
mutex_unlock(&priv->alloc_lock);
/* Wait until the Runtime PM code has woken up the device */
pm_runtime_get_sync(&priv->pdev->dev);
- return ret;
+ return 0;
}

static int uio_dmem_genirq_release(struct uio_info *info, struct inode *inode)
--
2.7.4




2019-01-22 11:01:34

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] uio:remove unneeded variable ret

On Wed, Jan 09, 2019 at 07:53:59PM +0800, wangbo wrote:
> In uio_dmem_genirq_open the variable ret is unneededw,remove it now.

Minor typo in this sentence :(

>
> Signed-off-by: wangbo <[email protected]>

I need a "full" name for a patch to be able to be accepted.

thanks,

greg k-h