2019-01-24 11:07:36

by Maciej Żenczykowski

[permalink] [raw]
Subject: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

From: Maciej Żenczykowski <[email protected]>

__bpf_redirect() and act_mirred checks this boolean
to determine whether to prefix an ethernet header.

Signed-off-by: Maciej Żenczykowski <[email protected]>
---
include/linux/if_arp.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/if_arp.h b/include/linux/if_arp.h
index 6756fea18b69..e44746de95cd 100644
--- a/include/linux/if_arp.h
+++ b/include/linux/if_arp.h
@@ -54,6 +54,7 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev)
case ARPHRD_IPGRE:
case ARPHRD_VOID:
case ARPHRD_NONE:
+ case ARPHRD_RAWIP:
return false;
default:
return true;
--
2.20.1.321.g9e740568ce-goog



2019-01-24 11:27:43

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

On 01/24/2019 12:07 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <[email protected]>
>
> __bpf_redirect() and act_mirred checks this boolean
> to determine whether to prefix an ethernet header.
>
> Signed-off-by: Maciej Żenczykowski <[email protected]>

I presume David would pick this up for net tree, so:

Acked-by: Daniel Borkmann <[email protected]>

2019-01-25 06:46:57

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

From: Maciej ?enczykowski <[email protected]>
Date: Thu, 24 Jan 2019 03:07:02 -0800

> From: Maciej ?enczykowski <[email protected]>
>
> __bpf_redirect() and act_mirred checks this boolean
> to determine whether to prefix an ethernet header.
>
> Signed-off-by: Maciej ?enczykowski <[email protected]>

Applied.