2019-01-24 19:33:18

by Sinan Kaya

[permalink] [raw]
Subject: [for next][PATCH v3 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC

Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.

ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_LCD_SUPPORT.

Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix

WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
Selected by [y]:
- ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)

Signed-off-by: Sinan Kaya <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 5e2109c54c7c..11810591840d 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -905,6 +905,7 @@ config TOSHIBA_WMI
config ACPI_CMPC
tristate "CMPC Laptop Extras"
depends on ACPI && INPUT
+ depends on BACKLIGHT_LCD_SUPPORT
depends on RFKILL || RFKILL=n
select BACKLIGHT_CLASS_DEVICE
help
--
2.19.0



2019-01-24 20:07:04

by Sinan Kaya

[permalink] [raw]
Subject: [for next][PATCH v3 2/2] platform/x86: Fix unmet dependency warning for SAMSUNG_Q10

Add BACKLIGHT_LCD_SUPPORT for SAMSUNG_Q10 to fix the
warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.

SAMSUNG_Q10 selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_LCD_SUPPORT.

Copy BACKLIGHT_LCD_SUPPORT dependency into SAMSUNG_Q10 to fix:

WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
Selected by [y]:
- SAMSUNG_Q10 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y]

Signed-off-by: Sinan Kaya <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 11810591840d..b5e9db85e881 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1129,6 +1129,7 @@ config INTEL_OAKTRAIL
config SAMSUNG_Q10
tristate "Samsung Q10 Extras"
depends on ACPI
+ depends on BACKLIGHT_LCD_SUPPORT
select BACKLIGHT_CLASS_DEVICE
---help---
This driver provides support for backlight control on Samsung Q10
--
2.19.0


2019-01-24 21:34:29

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [for next][PATCH v3 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC

On Thu, Jan 24, 2019 at 9:31 PM Sinan Kaya <[email protected]> wrote:
>
> Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
>
> ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_LCD_SUPPORT.
>
> Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix
>
> WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
> Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
> Selected by [y]:
> - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
>

Acked-by: Andy Shevchenko <[email protected]>

for both patches in case Rafael takes care of them.

> Signed-off-by: Sinan Kaya <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 5e2109c54c7c..11810591840d 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -905,6 +905,7 @@ config TOSHIBA_WMI
> config ACPI_CMPC
> tristate "CMPC Laptop Extras"
> depends on ACPI && INPUT
> + depends on BACKLIGHT_LCD_SUPPORT
> depends on RFKILL || RFKILL=n
> select BACKLIGHT_CLASS_DEVICE
> help
> --
> 2.19.0
>


--
With Best Regards,
Andy Shevchenko

2019-01-30 23:57:46

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [for next][PATCH v3 1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC

On Thursday, January 24, 2019 10:32:56 PM CET Andy Shevchenko wrote:
> On Thu, Jan 24, 2019 at 9:31 PM Sinan Kaya <[email protected]> wrote:
> >
> > Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the
> > warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE.
> >
> > ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE
> > depends on BACKLIGHT_LCD_SUPPORT.
> >
> > Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix
> >
> > WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
> > Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
> > Selected by [y]:
> > - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n)
> >
>
> Acked-by: Andy Shevchenko <[email protected]>
>
> for both patches in case Rafael takes care of them.

So both applied, thanks!