2019-01-28 23:08:43

by Rajat Jain

Subject: [PATCH] Bluetooth: btusb: btusb_intel_cmd_timeout: use sleeping functions

The btusb_intel_cmd_timeout() is called from workqueue contexts,
so use the helper functions that can sleep.

Signed-off-by: Rajat Jain <[email protected]>

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5de0c2e59b97..9a890b2a7ee1 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -523,9 +523,9 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev)
}

bt_dev_err(hdev, "Initiating HW reset via gpio");
- gpiod_set_value(reset_gpio, 1);
- mdelay(100);
- gpiod_set_value(reset_gpio, 0);
+ gpiod_set_value_cansleep(reset_gpio, 1);
+ msleep(100);
+ gpiod_set_value_cansleep(reset_gpio, 0);
}

static inline void btusb_free_frags(struct btusb_data *data)
--
2.20.1.495.gaa96b0ce6b-goog

2019-01-29 15:13:42

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btusb: btusb_intel_cmd_timeout: use sleeping functions

Hi Rajat,

> The btusb_intel_cmd_timeout() is called from workqueue contexts,
> so use the helper functions that can sleep.
>
> Signed-off-by: Rajat Jain <[email protected]>

patch has been applied to bluetooth-next tree.

Regards

Marcel