2019-02-05 12:28:07

by David Engraf

[permalink] [raw]
Subject: [PATCH] device: Fix comment for driver_data in struct device

dev_set_drvdata/dev_get_drvdata is used to access driver_data
in struct device.

Signed-off-by: David Engraf <[email protected]>
---
include/linux/device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/device.h b/include/linux/device.h
index 6cb4640b6160..601594771153 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -985,7 +985,7 @@ struct device {
void *platform_data; /* Platform specific data, device
core doesn't touch it */
void *driver_data; /* Driver data, set and get with
- dev_set/get_drvdata */
+ dev_set_drvdata/dev_get_drvdata */
struct dev_links_info links;
struct dev_pm_info power;
struct dev_pm_domain *pm_domain;
--
2.17.1



2019-02-05 13:40:36

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] device: Fix comment for driver_data in struct device

On Tue, Feb 05, 2019 at 01:19:52PM +0100, David Engraf wrote:
> dev_set_drvdata/dev_get_drvdata is used to access driver_data
> in struct device.

The original comment might be slight confusing, though we all know the concept
of getters and setters.

> void *platform_data; /* Platform specific data, device
> core doesn't touch it */
> void *driver_data; /* Driver data, set and get with
> - dev_set/get_drvdata */
> + dev_set_drvdata/dev_get_drvdata */
> struct dev_links_info links;
> struct dev_pm_info power;
> struct dev_pm_domain *pm_domain;
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko



2019-02-06 07:58:17

by David Engraf

[permalink] [raw]
Subject: Re: [PATCH] device: Fix comment for driver_data in struct device

On 05.02.19 at 14:23, Andy Shevchenko wrote:
> On Tue, Feb 05, 2019 at 01:19:52PM +0100, David Engraf wrote:
>> dev_set_drvdata/dev_get_drvdata is used to access driver_data
>> in struct device.
>
> The original comment might be slight confusing, though we all know the concept
> of getters and setters.

Okay you're right. I was a bit confused about the syntax.

Thanks
- David


>> void *platform_data; /* Platform specific data, device
>> core doesn't touch it */
>> void *driver_data; /* Driver data, set and get with
>> - dev_set/get_drvdata */
>> + dev_set_drvdata/dev_get_drvdata */
>> struct dev_links_info links;
>> struct dev_pm_info power;
>> struct dev_pm_domain *pm_domain;
>> --
>> 2.17.1
>>
>