2019-02-13 13:50:11

by Martin Kepplinger

Subject: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()

gpiod_set_value_cansleep() needs it's declaration in the corresponding
header. This fixes build errors like

drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
>> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
[-Werror=implicit-function-declaration]
gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
^~~~~~~~~~~~~~~~~~~~~~~~
gpio_set_value_cansleep

Signed-off-by: Martin Kepplinger <[email protected]>
---

drivers/input/touchscreen/st1232.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
index 1fbc0847416b..f4b7a4f1c366 100644
--- a/drivers/input/touchscreen/st1232.c
+++ b/drivers/input/touchscreen/st1232.c
@@ -18,6 +18,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/pm_qos.h>
#include <linux/slab.h>
#include <linux/types.h>
--
2.20.1

2019-02-17 08:30:55

by Dmitry Torokhov

Subject: Re: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()

On Wed, Feb 13, 2019 at 12:19:58PM +0100, Martin Kepplinger wrote:
> gpiod_set_value_cansleep() needs it's declaration in the corresponding
> header. This fixes build errors like
>
> drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power':
> >> drivers/input/touchscreen/st1232.c:146:3: error: implicit declaration of
> function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'?
> [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(ts->reset_gpio, !poweron);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> gpio_set_value_cansleep
>
> Signed-off-by: Martin Kepplinger <[email protected]>

Thanks Martin, I'll fold it into the original patch introducing gpiod so
we keep bisectability.

--
Dmitry