2019-02-15 14:57:25

by Baolin Wang

Subject: [PATCH v2 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string

Use SoC compatible string instead of wildcard string.

Signed-off-by: Baolin Wang <[email protected]>
---
Changes from v1:
- Add 'sprd' to indicate the module in subject line.
---
.../devicetree/bindings/gpio/gpio-eic-sprd.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
index 93d98d0..54040a2 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-eic-sprd.txt
@@ -33,7 +33,7 @@ Required properties:
"sprd,sc9860-eic-latch",
"sprd,sc9860-eic-async",
"sprd,sc9860-eic-sync",
- "sprd,sc27xx-eic".
+ "sprd,sc2731-eic".
- reg: Define the base and range of the I/O address space containing
the GPIO controller registers.
- gpio-controller: Marks the device node as a GPIO controller.
@@ -86,7 +86,7 @@ Example:
};

pmic_eic: gpio@300 {
- compatible = "sprd,sc27xx-eic";
+ compatible = "sprd,sc2731-eic";
reg = <0x300>;
interrupt-parent = <&sc2731_pmic>;
interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
--
1.7.9.5

2019-02-15 14:58:31

by Baolin Wang

Subject: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string

Change to use SoC compatible string instead of wildcard string.

Signed-off-by: Baolin Wang <[email protected]>
---
Changes from v1:
- None.
---
drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index ac573da..24228cf 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
}

static const struct of_device_id sprd_pmic_eic_of_match[] = {
- { .compatible = "sprd,sc27xx-eic", },
+ { .compatible = "sprd,sc2731-eic", },
{ /* end of list */ }
};
MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
--
1.7.9.5

2019-02-18 20:09:17

by Rob Herring (Arm)

Subject: Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string

On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote:
> Change to use SoC compatible string instead of wildcard string.
>
> Signed-off-by: Baolin Wang <[email protected]>
> ---
> Changes from v1:
> - None.
> ---
> drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index ac573da..24228cf 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id sprd_pmic_eic_of_match[] = {
> - { .compatible = "sprd,sc27xx-eic", },
> + { .compatible = "sprd,sc2731-eic", },

You need to keep the old one if you care about backwards compatibility.
If you don't then state why in the commit message.

> { /* end of list */ }
> };
> MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> --
> 1.7.9.5
>

2019-02-18 20:09:42

by Rob Herring (Arm)

Subject: Re: [PATCH v2 1/2] dt-bindings: gpio: sprd: Use SoC compatible string instead of wildcard string

On Fri, 15 Feb 2019 12:55:18 +0800, Baolin Wang wrote:
> Use SoC compatible string instead of wildcard string.
>
> Signed-off-by: Baolin Wang <[email protected]>
> ---
> Changes from v1:
> - Add 'sprd' to indicate the module in subject line.
> ---
> .../devicetree/bindings/gpio/gpio-eic-sprd.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2019-02-19 02:51:02

by Baolin Wang

Subject: Re: [PATCH v2 2/2] gpio: sprd: Change to use SoC compatible string

On Tue, 19 Feb 2019 at 04:07, Rob Herring <[email protected]> wrote:
>
> On Fri, Feb 15, 2019 at 12:55:19PM +0800, Baolin Wang wrote:
> > Change to use SoC compatible string instead of wildcard string.
> >
> > Signed-off-by: Baolin Wang <[email protected]>
> > ---
> > Changes from v1:
> > - None.
> > ---
> > drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> > index ac573da..24228cf 100644
> > --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> > @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
> > }
> >
> > static const struct of_device_id sprd_pmic_eic_of_match[] = {
> > - { .compatible = "sprd,sc27xx-eic", },
> > + { .compatible = "sprd,sc2731-eic", },
>
> You need to keep the old one if you care about backwards compatibility.
> If you don't then state why in the commit message.
>

As we discussed before, our dts and drivers development are still in
progress, and we always recompile and ship device trees at the same
time as we compile and ship the kernel, so we do not need care about
backwards compatibility.

Yes, I will add the explanation in the commit message. Thanks.

--
Baolin Wang
Best Regards