2019-02-19 08:40:24

by Alexey Roslyakov

[permalink] [raw]
Subject: [PATCH] rtc: pcf85063: remove dead code

Some of defines are not in use since
7b5768486a910532885f01b9d2dad4818c8b3be1. Remove it to make the code
easier to read and understand.

Signed-off-by: Alexey Roslyakov <[email protected]>
---
drivers/rtc/rtc-pcf85063.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index 283c2335b01b..0a00d39eb877 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -28,16 +28,9 @@

#define PCF85063_REG_CTRL1 0x00 /* status */
#define PCF85063_REG_CTRL1_STOP BIT(5)
-#define PCF85063_REG_CTRL2 0x01

#define PCF85063_REG_SC 0x04 /* datetime */
#define PCF85063_REG_SC_OS 0x80
-#define PCF85063_REG_MN 0x05
-#define PCF85063_REG_HR 0x06
-#define PCF85063_REG_DM 0x07
-#define PCF85063_REG_DW 0x08
-#define PCF85063_REG_MO 0x09
-#define PCF85063_REG_YR 0x0A

static struct i2c_driver pcf85063_driver;

--
2.19.2



2019-03-02 20:59:08

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] rtc: pcf85063: remove dead code

On 19/02/2019 15:39:29+0700, Alexey Roslyakov wrote:
> Some of defines are not in use since
> 7b5768486a910532885f01b9d2dad4818c8b3be1. Remove it to make the code
> easier to read and understand.
>
> Signed-off-by: Alexey Roslyakov <[email protected]>
> ---
> drivers/rtc/rtc-pcf85063.c | 7 -------
> 1 file changed, 7 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com