2019-02-19 23:56:56

by Brendan Higgins

[permalink] [raw]
Subject: [PATCH v3] of: unittest: unflatten device tree on UML when testing

UML supports enabling OF, and is useful for running the device tree
tests, so add support for unflattening device tree blobs so we can
actually use it.

Signed-off-by: Brendan Higgins <[email protected]>
---
drivers/of/unittest.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 84427384654d5..98f0dfc91c2a3 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2514,6 +2514,10 @@ static int __init of_unittest(void)
int res;

/* adding data for unittest */
+
+ if (IS_ENABLED(CONFIG_UML))
+ unittest_unflatten_overlay_base();
+
res = unittest_data_add();
if (res)
return res;
--
2.21.0.rc0.258.g878e2cd30e-goog



2019-02-20 01:50:23

by Frank Rowand

[permalink] [raw]
Subject: Re: [PATCH v3] of: unittest: unflatten device tree on UML when testing

On 2/19/19 3:54 PM, Brendan Higgins wrote:
> UML supports enabling OF, and is useful for running the device tree
> tests, so add support for unflattening device tree blobs so we can
> actually use it.
>
> Signed-off-by: Brendan Higgins <[email protected]>
> ---
> drivers/of/unittest.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 84427384654d5..98f0dfc91c2a3 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -2514,6 +2514,10 @@ static int __init of_unittest(void)
> int res;
>
> /* adding data for unittest */
> +
> + if (IS_ENABLED(CONFIG_UML))
> + unittest_unflatten_overlay_base();
> +
> res = unittest_data_add();
> if (res)
> return res;
>


Reviewed-by: Frank Rowand <[email protected]>