Hi all,
In commit
a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
Fixes tag
Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
has these problem(s):
- Target SHA1 does not exist
Did you mean:
Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
--
Cheers,
Stephen Rothwell
On 20-02-19, 09:31, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>
> Fixes tag
>
> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean:
>
> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
Yes looks like I messed up the commit id.. Not sure why :(
Dave would you like to drop this and me sending updated patch or
something else..
Sorry about the miss
--
~Vinod
Hi Vinod,
On Wed, 20 Feb 2019 10:10:55 +0530 Vinod Koul <[email protected]> wrote:
>
> Dave would you like to drop this and me sending updated patch or
> something else..
Dave doesn't rebase/reset net-next, so we will just have to use this as
a learning experience :-)
--
Cheers,
Stephen Rothwell
From: Vinod Koul <[email protected]>
Date: Wed, 20 Feb 2019 10:10:55 +0530
> On 20-02-19, 09:31, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>
>> Fixes tag
>>
>> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>
>> has these problem(s):
>>
>> - Target SHA1 does not exist
>>
>> Did you mean:
>>
>> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>
> Yes looks like I messed up the commit id.. Not sure why :(
>
> Dave would you like to drop this and me sending updated patch or
> something else..
>
> Sorry about the miss
Doesn't work that way, something in my tree is there forever.
Wed, Feb 20, 2019 at 07:48:13AM CET, [email protected] wrote:
>From: Vinod Koul <[email protected]>
>Date: Wed, 20 Feb 2019 10:10:55 +0530
>
>> On 20-02-19, 09:31, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode")
>>>
>>> Fixes tag
>>>
>>> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode")
>>>
>>> has these problem(s):
>>>
>>> - Target SHA1 does not exist
>>>
>>> Did you mean:
>>>
>>> Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay for RGMII mode")
>>
>> Yes looks like I messed up the commit id.. Not sure why :(
>>
>> Dave would you like to drop this and me sending updated patch or
>> something else..
>>
>> Sorry about the miss
>
>Doesn't work that way, something in my tree is there forever.
Would be good to have some robot checking "Fixes" sanity...
From: Jiri Pirko <[email protected]>
Date: Wed, 20 Feb 2019 09:36:11 +0100
> Would be good to have some robot checking "Fixes" sanity...
I want to add a script to my trees that locally do it for me but the
backlog for patch review for me is so huge that I never get to "fun"
tasks like that....
This has been discussed before too.
On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
David Miller <[email protected]> wrote:
> From: Jiri Pirko <[email protected]>
> Date: Wed, 20 Feb 2019 09:36:11 +0100
>
> > Would be good to have some robot checking "Fixes" sanity...
>
> I want to add a script to my trees that locally do it for me but the
> backlog for patch review for me is so huge that I never get to "fun"
> tasks like that....
If it helps, this is what I use after being bitten once:
#!/bin/sh
[ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
grep "^Fixes: " "${1}" | while read -r f; do
sha="$(echo "${f}" | cut -d' ' -f2)"
if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
echo "Bad tag: ${f}" && exit 1
fi
done
--
Stefano
Wed, Feb 20, 2019 at 08:02:01PM CET, [email protected] wrote:
>From: Jiri Pirko <[email protected]>
>Date: Wed, 20 Feb 2019 09:36:11 +0100
>
>> Would be good to have some robot checking "Fixes" sanity...
>
>I want to add a script to my trees that locally do it for me but the
When it is in tree, it's already late. The robot has to check
emails/patchwork.
>backlog for patch review for me is so huge that I never get to "fun"
>tasks like that....
>
>This has been discussed before too.
From: Jiri Pirko <[email protected]>
Date: Wed, 20 Feb 2019 20:58:11 +0100
> Wed, Feb 20, 2019 at 08:02:01PM CET, [email protected] wrote:
>>From: Jiri Pirko <[email protected]>
>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>
>>> Would be good to have some robot checking "Fixes" sanity...
>>
>>I want to add a script to my trees that locally do it for me but the
>
> When it is in tree, it's already late. The robot has to check
> emails/patchwork.
It's for me, on my computer, to abort things when I try to commit
with a bad fixes tag or missing signoff.
From: Stefano Brivio <[email protected]>
Date: Wed, 20 Feb 2019 20:59:10 +0100
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <[email protected]> wrote:
>
>> From: Jiri Pirko <[email protected]>
>> Date: Wed, 20 Feb 2019 09:36:11 +0100
>>
>> > Would be good to have some robot checking "Fixes" sanity...
>>
>> I want to add a script to my trees that locally do it for me but the
>> backlog for patch review for me is so huge that I never get to "fun"
>> tasks like that....
>
> If it helps, this is what I use after being bitten once:
Awesome, thanks! You put this in as a pre-commit script?
Wed, Feb 20, 2019 at 09:25:22PM CET, [email protected] wrote:
>From: Jiri Pirko <[email protected]>
>Date: Wed, 20 Feb 2019 20:58:11 +0100
>
>> Wed, Feb 20, 2019 at 08:02:01PM CET, [email protected] wrote:
>>>From: Jiri Pirko <[email protected]>
>>>Date: Wed, 20 Feb 2019 09:36:11 +0100
>>>
>>>> Would be good to have some robot checking "Fixes" sanity...
>>>
>>>I want to add a script to my trees that locally do it for me but the
>>
>> When it is in tree, it's already late. The robot has to check
>> emails/patchwork.
>
>It's for me, on my computer, to abort things when I try to commit
>with a bad fixes tag or missing signoff.
Okay, but still, robot checking emails/patchwork would safe you some
overhead.
On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller <[email protected]> wrote:
> From: Stefano Brivio <[email protected]>
> Date: Wed, 20 Feb 2019 20:59:10 +0100
>
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller <[email protected]> wrote:
> >
> >> From: Jiri Pirko <[email protected]>
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>
> >> > Would be good to have some robot checking "Fixes" sanity...
> >>
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that....
> >
> > If it helps, this is what I use after being bitten once:
>
> Awesome, thanks! You put this in as a pre-commit script?
Nope, I use it before sending patches out with git send-email.
But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):
#!/bin/sh
grep "^Fixes: " "${1}" | while read -r f; do
sha="$(echo "${f}" | cut -d' ' -f2)"
if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
echo "Bad tag: ${f}" && exit 1
fi
done
--
Stefano
From: Stefano Brivio <[email protected]>
Date: Wed, 20 Feb 2019 21:37:29 +0100
> On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
> David Miller <[email protected]> wrote:
>
>> From: Stefano Brivio <[email protected]>
>> Date: Wed, 20 Feb 2019 20:59:10 +0100
>>
>> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
>> > David Miller <[email protected]> wrote:
>> >
>> >> From: Jiri Pirko <[email protected]>
>> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
>> >>
>> >> > Would be good to have some robot checking "Fixes" sanity...
>> >>
>> >> I want to add a script to my trees that locally do it for me but the
>> >> backlog for patch review for me is so huge that I never get to "fun"
>> >> tasks like that....
>> >
>> > If it helps, this is what I use after being bitten once:
>>
>> Awesome, thanks! You put this in as a pre-commit script?
>
> Nope, I use it before sending patches out with git send-email.
>
> But you can use this as .git/hooks/commit-msg, just skip taking the
> tree as second argument, something like this (just quickly tested):
Awesome, thank you!
On 20-02-19, 20:59, Stefano Brivio wrote:
> On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> David Miller <[email protected]> wrote:
>
> > From: Jiri Pirko <[email protected]>
> > Date: Wed, 20 Feb 2019 09:36:11 +0100
> >
> > > Would be good to have some robot checking "Fixes" sanity...
> >
> > I want to add a script to my trees that locally do it for me but the
> > backlog for patch review for me is so huge that I never get to "fun"
> > tasks like that....
>
> If it helps, this is what I use after being bitten once:
>
> #!/bin/sh
>
> [ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1
> grep "^Fixes: " "${1}" | while read -r f; do
> sha="$(echo "${f}" | cut -d' ' -f2)"
> if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
> echo "Bad tag: ${f}" && exit 1
> fi
> done
Awesome thanks, I am adding this into my patch commit script and well as
send script
--
~Vinod