2019-02-20 05:02:30

by Vaishali Thakkar

Subject: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

From: Vinod Koul <[email protected]>

Qcom Socinfo driver can be built as a module, so
export these two APIs.

Signed-off-by: Vinod Koul <[email protected]>
Signed-off-by: Vaishali Thakkar <[email protected]>
---
Changes since v1:
- None
---
drivers/base/soc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index b0933b9fe67f..7c0c5ca5953d 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -164,6 +164,7 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr
out1:
return ERR_PTR(ret);
}
+EXPORT_SYMBOL_GPL(soc_device_register);

/* Ensure soc_dev->attr is freed prior to calling soc_device_unregister. */
void soc_device_unregister(struct soc_device *soc_dev)
@@ -173,6 +174,7 @@ void soc_device_unregister(struct soc_device *soc_dev)
device_unregister(&soc_dev->dev);
early_soc_dev_attr = NULL;
}
+EXPORT_SYMBOL_GPL(soc_device_unregister);

static int __init soc_bus_register(void)
{
--
2.17.1

2019-02-20 06:56:39

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote:
> From: Vinod Koul <[email protected]>
>
> Qcom Socinfo driver can be built as a module, so
> export these two APIs.
>
> Signed-off-by: Vinod Koul <[email protected]>
> Signed-off-by: Vaishali Thakkar <[email protected]>
> ---
> Changes since v1:
> - None

This is fixing a build breakage introduced by an earlier patch. Please
rearange the patches so that breakage never happens.

Also, any chance you can properly "thread" your patches so they all show
up together? git send-email does this automatically...

thanks,

greg k-h

2019-02-20 08:50:36

by Vaishali Thakkar

Subject: Re: [PATCH v2 5/5] base: soc: Export soc_device_register/unregister APIs

On Wed, 20 Feb 2019 at 12:25, Greg KH <[email protected]> wrote:
>
> On Wed, Feb 20, 2019 at 10:29:46AM +0530, Vaishali Thakkar wrote:
> > From: Vinod Koul <[email protected]>
> >
> > Qcom Socinfo driver can be built as a module, so
> > export these two APIs.
> >
> > Signed-off-by: Vinod Koul <[email protected]>
> > Signed-off-by: Vaishali Thakkar <[email protected]>
> > ---
> > Changes since v1:
> > - None
>
> This is fixing a build breakage introduced by an earlier patch. Please
> rearange the patches so that breakage never happens.

Ok, yes. I'll put it as patch two [before adding socinfo driver].

> Also, any chance you can properly "thread" your patches so they all show
> up together? git send-email does this automatically...

I'm using send-email only but I was sending it one by one. I believe
that's the reason why didn't come as a thread. I'll fix that in next version
too.

> thanks,
>
> greg k-h