2019-02-19 17:29:32

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186

Tegra186 does not have master FIFO control register and instead
uses FIFO control register like prior Tegra chipset.

This patch fixes this and prevents crashing during boot when
accessing FIFO control registers.

Acked-by: Thierry Reding <[email protected]>
Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a4cd79c9f7a7..e6851904acc1 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.has_config_load_reg = true,
.has_multi_master_mode = true,
.has_slcg_override_reg = true,
- .has_mst_fifo = true,
+ .has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
.supports_bus_clear = true,
.has_apb_dma = false,
--
2.7.4



2019-02-19 17:31:07

by Sowjanya Komatineni

[permalink] [raw]
Subject: [PATCH V5 2/2] i2c: tegra: remove multi-master support

Multi-master support is defeatured on Tegra210 and Tegra186 due to
known bugs.

This patch removes multi-master support for Tegra210 and Tegra186
I2C HW feature.

Acked-by: Thierry Reding <[email protected]>
Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/i2c/busses/i2c-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e6851904acc1..26f686bc3491 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1409,7 +1409,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
@@ -1434,7 +1434,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = {
.clk_divisor_fast_mode = 0x19,
.clk_divisor_fast_plus_mode = 0x10,
.has_config_load_reg = true,
- .has_multi_master_mode = true,
+ .has_multi_master_mode = false,
.has_slcg_override_reg = true,
.has_mst_fifo = false,
.quirks = &tegra_i2c_quirks,
--
2.7.4


2019-02-23 09:29:48

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH V5 1/2] i2c: tegra: remove master fifo support on tegra186

On Tue, Feb 19, 2019 at 09:28:51AM -0800, Sowjanya Komatineni wrote:
> Tegra186 does not have master FIFO control register and instead
> uses FIFO control register like prior Tegra chipset.
>
> This patch fixes this and prevents crashing during boot when
> accessing FIFO control registers.
>
> Acked-by: Thierry Reding <[email protected]>
> Signed-off-by: Sowjanya Komatineni <[email protected]>

Applied to for-next, thanks!

Attachments:
(No filename) (449.00 B)
 signature.asc (849.00 B)
 Download all attachments

2019-02-23 09:29:48

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH V5 2/2] i2c: tegra: remove multi-master support

On Tue, Feb 19, 2019 at 09:28:52AM -0800, Sowjanya Komatineni wrote:
> Multi-master support is defeatured on Tegra210 and Tegra186 due to
> known bugs.
>
> This patch removes multi-master support for Tegra210 and Tegra186
> I2C HW feature.
>
> Acked-by: Thierry Reding <[email protected]>
> Signed-off-by: Sowjanya Komatineni <[email protected]>

Applied to for-next, thanks!

Attachments:
(No filename) (397.00 B)
 signature.asc (849.00 B)
 Download all attachments