2019-02-24 13:17:40

by Axel Lin

Subject: [PATCH] regulator: wm831x-dcdc: Fix list of wm831x_dcdc_ilim from mA to uA

The wm831x_dcdc_ilim entries needs to be uA because it is used to compare
with min_uA and max_uA.
While at it also make the array const and change to use unsigned int.

Fixes: e4ee831f949a ("regulator: Add WM831x DC-DC buck convertor support")
Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/wm831x-dcdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/wm831x-dcdc.c b/drivers/regulator/wm831x-dcdc.c
index 4a573eea284a..828f262d6be0 100644
--- a/drivers/regulator/wm831x-dcdc.c
+++ b/drivers/regulator/wm831x-dcdc.c
@@ -304,8 +304,8 @@ static int wm831x_buckv_get_voltage_sel(struct regulator_dev *rdev)
}

/* Current limit options */
-static u16 wm831x_dcdc_ilim[] = {
- 125, 250, 375, 500, 625, 750, 875, 1000
+static const unsigned int wm831x_dcdc_ilim[] = {
+ 125000, 250000, 375000, 500000, 625000, 750000, 875000, 1000000
};

static int wm831x_buckv_set_current_limit(struct regulator_dev *rdev,
--
2.17.1

2019-02-25 09:49:20

by Charles Keepax

Subject: Re: [PATCH] regulator: wm831x-dcdc: Fix list of wm831x_dcdc_ilim from mA to uA

On Sun, Feb 24, 2019 at 09:16:51PM +0800, Axel Lin wrote:
> The wm831x_dcdc_ilim entries needs to be uA because it is used to compare
> with min_uA and max_uA.
> While at it also make the array const and change to use unsigned int.
>
> Fixes: e4ee831f949a ("regulator: Add WM831x DC-DC buck convertor support")
> Signed-off-by: Axel Lin <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles