2019-02-26 06:01:40

by Bo YU

Subject: [PATCH] staging: wilc1000: fix incorrect type in initializer

Fix sparse warning following:

drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type in initializer (different address spaces)
drivers/staging/wilc1000/host_interface.c:444:49: expected struct cfg80211_bss_ies const *ies
drivers/staging/wilc1000/host_interface.c:444:49: got struct cfg80211_bss_ies const [noderef] <asn:4> *ies

Signed-off-by: Bo YU <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index cdcb52aec779..89ae22d40f71 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
int ret;
- const struct cfg80211_bss_ies *ies = bss->ies;
+ const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);

param = kzalloc(sizeof(*param), GFP_KERNEL);
if (!param)
--
2.11.0

2019-02-26 12:01:52

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wilc1000: fix incorrect type in initializer

On Tue, Feb 26, 2019 at 07:29:56PM +0800, Bo YU wrote:
> On Tue, Feb 26, 2019 at 2:00 PM Bo YU <[email protected]> wrote:
>
> > Fix sparse warning following:
> >
> > drivers/staging/wilc1000/host_interface.c:444:49: warning: incorrect type
> > in initializer (different address spaces)
> > drivers/staging/wilc1000/host_interface.c:444:49: expected struct
> > cfg80211_bss_ies const *ies
> > drivers/staging/wilc1000/host_interface.c:444:49: got struct
> > cfg80211_bss_ies const [noderef] <asn:4> *ies
> >
> > Signed-off-by: Bo YU <[email protected]>
> > ---
> > drivers/staging/wilc1000/host_interface.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/host_interface.c
> > b/drivers/staging/wilc1000/host_interface.c
> > index cdcb52aec779..89ae22d40f71 100644
> > --- a/drivers/staging/wilc1000/host_interface.c
> > +++ b/drivers/staging/wilc1000/host_interface.c
> > @@ -441,7 +441,7 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss
> > *bss,
> > const u8 *tim_elm, *ssid_elm, *rates_ie, *supp_rates_ie;
> > const u8 *ht_ie, *wpa_ie, *wmm_ie, *rsn_ie;
> > int ret;
> > - const struct cfg80211_bss_ies *ies = bss->ies;
> > + const struct cfg80211_bss_ies *ies = rcu_dereference(bss->ies);
> >
> > param = kzalloc(sizeof(*param), GFP_KERNEL);
> > if (!param)
> > --
> > 2.11.0
> >
> > Hi,
> I do not Ccing wireless-list, Does it matter?

It would be nice to do that in the future.