2019-02-26 17:00:18

by Colin King

Subject: [PATCH] drm/bridge: ti-sn65dsi86: make const array static

From: Colin Ian King <[email protected]>

Don't populate the const array ti_sn_bridge_supply_names on the
stack but instead make it static.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index f72ee137e5f1..4c2ca4e39be5 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
{
unsigned int i;
- const char * const ti_sn_bridge_supply_names[] = {
+ static const char * const ti_sn_bridge_supply_names[] = {
"vcca", "vcc", "vccio", "vpll",
};

--
2.20.1

2019-02-27 13:04:45

by Andrzej Hajda

Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: make const array static

On 26.02.2019 17:59, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the const array ti_sn_bridge_supply_names on the
> stack but instead make it static.
>
> Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Andrzej Hajda <[email protected]>

 --
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index f72ee137e5f1..4c2ca4e39be5 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -211,7 +211,7 @@ static struct ti_sn_bridge *bridge_to_ti_sn_bridge(struct drm_bridge *bridge)
> static int ti_sn_bridge_parse_regulators(struct ti_sn_bridge *pdata)
> {
> unsigned int i;
> - const char * const ti_sn_bridge_supply_names[] = {
> + static const char * const ti_sn_bridge_supply_names[] = {
> "vcca", "vcc", "vccio", "vpll",
> };
>