2019-02-27 07:18:10

by Moriis Ku

[permalink] [raw]
Subject: [PATCH 1/5] Add support SUNIX Multi-I/O board

Add Kconfig and Makefile entry.

---
Kconfig | 2 ++
Makefile | 1 +
2 files changed, 3 insertions(+)

diff --git a/Kconfig b/Kconfig
index 4f9f9905..645dcc85 100644
--- a/Kconfig
+++ b/Kconfig
@@ -228,4 +228,6 @@ source "drivers/siox/Kconfig"

source "drivers/slimbus/Kconfig"

+source "drivers/char/snx/Kconfig"
+
endmenu
diff --git a/Makefile b/Makefile
index e1ce029d..c9393c75 100644
--- a/Makefile
+++ b/Makefile
@@ -186,3 +186,4 @@ obj-$(CONFIG_MULTIPLEXER) += mux/
obj-$(CONFIG_UNISYS_VISORBUS) += visorbus/
obj-$(CONFIG_SIOX) += siox/
obj-$(CONFIG_GNSS) += gnss/
+obj-$(CONFIG_SNX) += snx/
--
2.17.1



2019-02-27 08:18:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 1/5] Add support SUNIX Multi-I/O board

On Wed, Feb 27, 2019 at 03:17:02PM +0800, Morris Ku wrote:
> Add Kconfig and Makefile entry.
>
> ---
> Kconfig | 2 ++
> Makefile | 1 +
> 2 files changed, 3 insertions(+)

<snip>

Oh, this series has lots of issues, not the least being this single
patch breaks the build :(

Every patch needs to build properly, or at the least, not stop
everything else from building.

I recommend reading Documentation/SubmittingPatches for how to do a
patch submission properly, and if you have specific questions after
reading that, I will be glad to answer them.

Also, please use scripts/checkpatch.pl on your patches, it will point
out lots of issues that I'll be nice and not mention at the moment :)

thanks,

greg k-h