2018-11-28 16:13:54

by Colin King

Subject: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

From: Colin Ian King <[email protected]>

There is a spelling mistake in array speakup_default_msgs at index
MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index cea8707653f5..ee240d36f947 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -336,7 +336,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
[MSG_FUNCNAME_SPELL_DELAY_DEC] = "spell delay decrement",
[MSG_FUNCNAME_SPELL_DELAY_INC] = "spell delay increment",
[MSG_FUNCNAME_SPELL_WORD] = "spell word",
- [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
+ [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
[MSG_FUNCNAME_TONE_DEC] = "tone decrement",
[MSG_FUNCNAME_TONE_INC] = "tone increment",
[MSG_FUNCNAME_VOICE_DEC] = "voice decrement",
--
2.19.1

2018-11-28 16:18:12

by Samuel Thibault

Subject: Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

Hello,

Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
> + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",

Mmm, clearly an english typo. Speakup people, do you think there might
be any downside here? Could it be that it was done on purpose for e.g.
syntheses to pronounce it right?

Samuel

2019-03-02 20:38:50

by Samuel Thibault

Subject: Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

Hello,

Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> From: Colin Ian King <[email protected]>
>
> There is a spelling mistake in array speakup_default_msgs at index
> MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.
>
> Signed-off-by: Colin Ian King <[email protected]>

We never got any feedback from the speakup mailing list, I guess fixing
the typo is fine.

Reviewed-by: Samuel Thibault <[email protected]>

> ---
> drivers/staging/speakup/i18n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index cea8707653f5..ee240d36f947 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -336,7 +336,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = {
> [MSG_FUNCNAME_SPELL_DELAY_DEC] = "spell delay decrement",
> [MSG_FUNCNAME_SPELL_DELAY_INC] = "spell delay increment",
> [MSG_FUNCNAME_SPELL_WORD] = "spell word",
> - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly",
> + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically",
> [MSG_FUNCNAME_TONE_DEC] = "tone decrement",
> [MSG_FUNCNAME_TONE_INC] = "tone increment",
> [MSG_FUNCNAME_VOICE_DEC] = "voice decrement",
> --
> 2.19.1
>

2019-03-02 21:34:08

by Chris Brannon

Subject: Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

Samuel Thibault writes:
> Hello,
>
> Colin King, le mer. 28 nov. 2018 16:12:32 +0000, a ecrit:
> > From: Colin Ian King <[email protected]>
> >
> > There is a spelling mistake in array speakup_default_msgs at index
> > MSG_FUNCNAME_SPELL_WORD_PHONETICALLY, fix this.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> We never got any feedback from the speakup mailing list, I guess fixing
> the typo is fine.

I'm sure there were deliberate mis-spellings in Speakup error
messages to accomodate pronunciation issues with older synths, but I
have no idea whether this is one of them. It's probably fine either way.

-- Chris