2019-03-01 06:09:14

by Baoquan He

Subject: A quesiton about commit 3a63f70bf4c3

Hi Chao,

I am back porting this commit to our distrols from tip.
3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params

Findind out those SRAT handling related declarations are out of
BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?

Saw "misc.h" is included in several places, shouldn't be changed like
below? Please correct me if I was wrong.

Thanks
Baoquan

diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
index fd13655..252091b 100644
--- a/arch/x86/boot/compressed/misc.h
+++ b/arch/x86/boot/compressed/misc.h
@@ -120,8 +120,6 @@ static inline void console_init(void)

void set_sev_encryption_mask(void);

-#endif
-
/* acpi.c */
#ifdef CONFIG_ACPI
acpi_physical_address get_rsdp_addr(void);
@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
#else
static inline int count_immovable_mem_regions(void) { return 0; }
#endif
+#endif

2019-03-04 01:27:57

by Chao Fan

Subject: Re: A quesiton about commit 3a63f70bf4c3

On Fri, Mar 01, 2019 at 02:06:31PM +0800, Baoquan He wrote:
>
>Hi Chao,
Hi Baoquan,

Sorry for late reply, I was away from keyboard last Friday.
Your change looks good, I think you can format it as a real PATCH.
>
>I am back porting this commit to our distrols from tip.

Thanks for your effort.

Thanks,
Chao Fan

>3a63f70bf4c3 x86/boot: Early parse RSDP and save it in boot_params
>
>Findind out those SRAT handling related declarations are out of
>BOOT_COMPRESSED_MISC_H ifdeffery. Is this made on purpose?
>
>Saw "misc.h" is included in several places, shouldn't be changed like
>below? Please correct me if I was wrong.


>
>Thanks
>Baoquan
>
>diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
>index fd13655..252091b 100644
>--- a/arch/x86/boot/compressed/misc.h
>+++ b/arch/x86/boot/compressed/misc.h
>@@ -120,8 +120,6 @@ static inline void console_init(void)
>
> void set_sev_encryption_mask(void);
>
>-#endif
>-
> /* acpi.c */
> #ifdef CONFIG_ACPI
> acpi_physical_address get_rsdp_addr(void);
>@@ -135,3 +133,4 @@ int count_immovable_mem_regions(void);
> #else
> static inline int count_immovable_mem_regions(void) { return 0; }
> #endif
>+#endif
>
>

2019-03-04 04:21:02

by Baoquan He

Subject: Re: A quesiton about commit 3a63f70bf4c3

On 03/04/19 at 09:27am, Chao Fan wrote:
> On Fri, Mar 01, 2019 at 02:06:31PM +0800, Baoquan He wrote:
> >
> >Hi Chao,
> Hi Baoquan,
>
> Sorry for late reply, I was away from keyboard last Friday.
> Your change looks good, I think you can format it as a real PATCH.

Thx, sent.