2019-03-11 06:35:53

by Pi-Hsun Shih

[permalink] [raw]
Subject: [PATCH v6 1/7] dt-bindings: Add a binding for Mediatek SCP

From: Erin Lo <[email protected]>

Add a DT binding documentation of SCP for the
MT8183 SoC from Mediatek.

Signed-off-by: Erin Lo <[email protected]>
---
Changes from v5:
- Remove dependency on CONFIG_RPMSG_MTK_SCP.

Changes from v4:
- Add detail of more properties.
- Document the usage of mtk,rpmsg-name in subnode from the new design.

Changes from v3:
- No change.

Changes from v2:
- No change. I realized that for this patch series, there's no need to
add anything under the mt8183-scp node (neither the mt8183-rpmsg or
the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added
directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically
created by SCP name service.

Changes from v1:
- No change.
---
.../bindings/remoteproc/mtk,scp.txt | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
new file mode 100644
index 000000000000..3ba668bab14b
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
@@ -0,0 +1,36 @@
+Mediatek SCP Bindings
+----------------------------------------
+
+This binding provides support for ARM Cortex M4 Co-processor found on some
+Mediatek SoCs.
+
+Required properties:
+- compatible Should be "mediatek,mt8183-scp"
+- reg Should contain the address ranges for the two memory
+ regions, SRAM and CFG.
+- reg-names Contains the corresponding names for the two memory
+ regions. These should be named "sram" & "cfg".
+- clocks Clock for co-processor (See: ../clock/clock-bindings.txt)
+- clock-names Contains the corresponding name for the clock. This
+ should be named "main".
+
+Subnodes
+--------
+
+Subnodes of the SCP represent rpmsg devices. The names of the devices are not
+important. The properties of these nodes are defined by the individual bindings
+for the rpmsg devices - but must contain the following property:
+
+- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match
+ the subnode to rpmsg device announced by SCP.
+
+Example:
+
+ scp: scp@10500000 {
+ compatible = "mediatek,mt8183-scp";
+ reg = <0 0x10500000 0 0x80000>,
+ <0 0x105c0000 0 0x5000>;
+ reg-names = "sram", "cfg";
+ clocks = <&infracfg CLK_INFRA_SCPSYS>;
+ clock-names = "main";
+ };
--
2.21.0.360.g471c308f928-goog



2019-03-11 22:10:31

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v6 1/7] dt-bindings: Add a binding for Mediatek SCP

On Mon, 11 Mar 2019 14:34:52 +0800, Pi-Hsun Shih wrote:
> From: Erin Lo <[email protected]>
>
> Add a DT binding documentation of SCP for the
> MT8183 SoC from Mediatek.
>
> Signed-off-by: Erin Lo <[email protected]>
> ---
> Changes from v5:
> - Remove dependency on CONFIG_RPMSG_MTK_SCP.
>
> Changes from v4:
> - Add detail of more properties.
> - Document the usage of mtk,rpmsg-name in subnode from the new design.
>
> Changes from v3:
> - No change.
>
> Changes from v2:
> - No change. I realized that for this patch series, there's no need to
> add anything under the mt8183-scp node (neither the mt8183-rpmsg or
> the cros-ec-rpmsg) for them to work, since mt8183-rpmsg is added
> directly as a rproc_subdev by code, and cros-ec-rpmsg is dynamically
> created by SCP name service.
>
> Changes from v1:
> - No change.
> ---
> .../bindings/remoteproc/mtk,scp.txt | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt
>

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.