2019-03-11 13:49:47

by Hedi Berriche

Subject: Please revert 7212e37cbdf9 from 4.4-stable

Hi Greg,

Could you please revert

7212e37cbdf9 x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls

from 4.4-stable?

In 4.4-stable efi_runtime_lock as defined in drivers/firmware/efi/runtime-wrappers.c
is a spinlock (given it predates commit dce48e351c0d) and commit

f331e766c4be x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls

which 7212e37cbdf9 is a backport of, needs it to be a semaphore.

Cheers,
Hedi.
--
Be careful of reading health books, you might die of a misprint.
-- Mark Twain

2019-03-12 00:30:21

by Sasha Levin

Subject: Re: Please revert 7212e37cbdf9 from 4.4-stable

On Mon, Mar 11, 2019 at 01:48:14PM +0000, Hedi Berriche wrote:
>Hi Greg,
>
>Could you please revert
>
> 7212e37cbdf9 x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls
>
>from 4.4-stable?
>
>In 4.4-stable efi_runtime_lock as defined in drivers/firmware/efi/runtime-wrappers.c
>is a spinlock (given it predates commit dce48e351c0d) and commit
>
> f331e766c4be x86/platform/UV: Use efi_runtime_lock to serialise BIOS calls
>
>which 7212e37cbdf9 is a backport of, needs it to be a semaphore.

I've queued up the revert. I'm not sure how it ended up on 4.4 to begin
with; sorry about that and thank you.

--
Thanks,
Sasha