2019-03-13 09:24:58

by Peng Fan

Subject: [PATCH] arm64: dts: imx8qxp: fix mbox-cells

Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but
actually mu0-4 could be used to communicate with SCU. So fix the
mbox-cells.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 4c3dd95ed488..16766838ac77 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -328,7 +328,7 @@
compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
reg = <0x5d1b0000 0x10000>;
interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
- #mbox-cells = <0>;
+ #mbox-cells = <2>;
status = "disabled";
};

@@ -343,7 +343,7 @@
compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
reg = <0x5d1e0000 0x10000>;
interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
- #mbox-cells = <0>;
+ #mbox-cells = <2>;
status = "disabled";
};

@@ -351,7 +351,7 @@
compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
reg = <0x5d1f0000 0x10000>;
interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
- #mbox-cells = <0>;
+ #mbox-cells = <2>;
status = "disabled";
};

--
2.16.4

2019-03-15 10:24:56

by Aisheng Dong

Subject: RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells

> From: Peng Fan
>
> Subject: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
>
> Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but actually
> mu0-4 could be used to communicate with SCU. So fix the mbox-cells.
>
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Dong Aisheng

> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 4c3dd95ed488..16766838ac77 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -328,7 +328,7 @@
> compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1b0000 0x10000>;
> interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> - #mbox-cells = <0>;
> + #mbox-cells = <2>;
> status = "disabled";
> };
>
> @@ -343,7 +343,7 @@
> compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1e0000 0x10000>;
> interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> - #mbox-cells = <0>;
> + #mbox-cells = <2>;
> status = "disabled";
> };
>
> @@ -351,7 +351,7 @@
> compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> reg = <0x5d1f0000 0x10000>;
> interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> - #mbox-cells = <0>;
> + #mbox-cells = <2>;
> status = "disabled";
> };
>
> --
> 2.16.4

2019-03-21 04:46:40

by Peng Fan

Subject: RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells

Hi Shawn,

> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019??3??15?? 18:24
> To: Peng Fan <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; dl-linux-imx
> <[email protected]>; Anson Huang <[email protected]>; Daniel Baluta
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]
> Subject: RE: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
>
> > From: Peng Fan
> >
> > Subject: [PATCH] arm64: dts: imx8qxp: fix mbox-cells
> >
> > Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but actually
> > mu0-4 could be used to communicate with SCU. So fix the mbox-cells.
> >
> > Signed-off-by: Peng Fan <[email protected]>
>
> Reviewed-by: Dong Aisheng <[email protected]>

Would you pick up this patch?

Thanks,
Peng.

>
> Regards
> Dong Aisheng
>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 4c3dd95ed488..16766838ac77 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -328,7 +328,7 @@
> > compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > reg = <0x5d1b0000 0x10000>;
> > interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>;
> > - #mbox-cells = <0>;
> > + #mbox-cells = <2>;
> > status = "disabled";
> > };
> >
> > @@ -343,7 +343,7 @@
> > compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > reg = <0x5d1e0000 0x10000>;
> > interrupts = <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>;
> > - #mbox-cells = <0>;
> > + #mbox-cells = <2>;
> > status = "disabled";
> > };
> >
> > @@ -351,7 +351,7 @@
> > compatible = "fsl,imx8qxp-mu", "fsl,imx6sx-mu";
> > reg = <0x5d1f0000 0x10000>;
> > interrupts = <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
> > - #mbox-cells = <0>;
> > + #mbox-cells = <2>;
> > status = "disabled";
> > };
> >
> > --
> > 2.16.4

2019-03-21 11:37:38

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8qxp: fix mbox-cells

On Wed, Mar 13, 2019 at 09:24:19AM +0000, Peng Fan wrote:
> Currently lsio_mu1 is used by Linux Kernel with mbox-cells as 2, but
> actually mu0-4 could be used to communicate with SCU. So fix the
> mbox-cells.
>
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks.