Three fairly trivial cleanup patches from while I've been working on the CRTC
code on rcar-du.
The first is a small spelling error in the drm_crtc_state documentation, and
the following two are more directly cleaning up the rcar-du.
Kieran Bingham (3):
drm: fix subtle spelling error in drm_crtc_state
drm: rcar-du: crtc: make local functions static
drm: rcar-du: Remove unused prototypes
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 +++++----
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 --
include/drm/drm_crtc.h | 2 +-
3 files changed, 6 insertions(+), 7 deletions(-)
--
2.19.1
The CRTC suspend and resume functions have been replaced, but the
prototypes were not removed.
Remove the redundant definitions.
Signed-off-by: Kieran Bingham <[email protected]>
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
index bcb35b0b7612..3f339a7e8d14 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.h
@@ -97,8 +97,6 @@ enum rcar_du_output {
int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex,
unsigned int hwindex);
-void rcar_du_crtc_suspend(struct rcar_du_crtc *rcrtc);
-void rcar_du_crtc_resume(struct rcar_du_crtc *rcrtc);
void rcar_du_crtc_finish_page_flip(struct rcar_du_crtc *rcrtc);
--
2.19.1
The drm_crtc_state documentation contains a subtle misspelling of the
word subtle. Correct it.
Signed-off-by: Kieran Bingham <[email protected]>
---
include/drm/drm_crtc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 85abd3fe9e83..f2b3762636df 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -78,7 +78,7 @@ struct drm_plane_helper_funcs;
/**
* struct drm_crtc_state - mutable CRTC state
*
- * Note that the distinction between @enable and @active is rather subtile:
+ * Note that the distinction between @enable and @active is rather subtle:
* Flipping @active while @enable is set without changing anything else may
* never return in a failure from the &drm_mode_config_funcs.atomic_check
* callback. Userspace assumes that a DPMS On will always succeed. In other
--
2.19.1
The rcar_du_crtc_mode_valid() and rcar_du_crtc_get_crc_sources()
functions are accessed only through a function pointer table.
Convert the function definitions to be static to the module.
Signed-off-by: Kieran Bingham <[email protected]>
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 4cdea14d552f..57fd5c00494b 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -761,8 +761,9 @@ static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
rcar_du_vsp_atomic_flush(rcrtc);
}
-enum drm_mode_status rcar_du_crtc_mode_valid(struct drm_crtc *crtc,
- const struct drm_display_mode *mode)
+static enum drm_mode_status
+rcar_du_crtc_mode_valid(struct drm_crtc *crtc,
+ const struct drm_display_mode *mode)
{
struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
struct rcar_du_device *rcdu = rcrtc->group->dev;
@@ -981,8 +982,8 @@ static int rcar_du_crtc_verify_crc_source(struct drm_crtc *crtc,
return 0;
}
-const char *const *rcar_du_crtc_get_crc_sources(struct drm_crtc *crtc,
- size_t *count)
+static const char *const *
+rcar_du_crtc_get_crc_sources(struct drm_crtc *crtc, size_t *count)
{
struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
--
2.19.1
On Thu, Mar 14, 2019 at 10:04:18PM +0000, Kieran Bingham wrote:
> The drm_crtc_state documentation contains a subtle misspelling of the
> word subtle. Correct it.
>
> Signed-off-by: Kieran Bingham <[email protected]>
Reviewed-by: Daniel Vetter <[email protected]>
> ---
> include/drm/drm_crtc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index 85abd3fe9e83..f2b3762636df 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -78,7 +78,7 @@ struct drm_plane_helper_funcs;
> /**
> * struct drm_crtc_state - mutable CRTC state
> *
> - * Note that the distinction between @enable and @active is rather subtile:
> + * Note that the distinction between @enable and @active is rather subtle:
> * Flipping @active while @enable is set without changing anything else may
> * never return in a failure from the &drm_mode_config_funcs.atomic_check
> * callback. Userspace assumes that a DPMS On will always succeed. In other
> --
> 2.19.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On Thu, Mar 14, 2019 at 10:04:20PM +0000, Kieran Bingham wrote:
> The CRTC suspend and resume functions have been replaced, but the
> prototypes were not removed.
>
> Remove the redundant definitions.
>
> Signed-off-by: Kieran Bingham <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
On Thu, Mar 14, 2019 at 10:04:19PM +0000, Kieran Bingham wrote:
> The rcar_du_crtc_mode_valid() and rcar_du_crtc_get_crc_sources()
> functions are accessed only through a function pointer table.
>
> Convert the function definitions to be static to the module.
>
> Signed-off-by: Kieran Bingham <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
On Thu, Mar 14, 2019 at 10:04:18PM +0000, Kieran Bingham wrote:
> The drm_crtc_state documentation contains a subtle misspelling of the
> word subtle. Correct it.
>
> Signed-off-by: Kieran Bingham <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
Hi Kieran,
Thank you for the patches.
On Thu, Mar 14, 2019 at 10:04:17PM +0000, Kieran Bingham wrote:
> Three fairly trivial cleanup patches from while I've been working on the CRTC
> code on rcar-du.
>
> The first is a small spelling error in the drm_crtc_state documentation, and
> the following two are more directly cleaning up the rcar-du.
>
> Kieran Bingham (3):
> drm: fix subtle spelling error in drm_crtc_state
> drm: rcar-du: crtc: make local functions static
> drm: rcar-du: Remove unused prototypes
For the whole series:
Reviewed-by: Laurent Pinchart <[email protected]>
and taken in my tree.
> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 +++++----
> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 --
> include/drm/drm_crtc.h | 2 +-
> 3 files changed, 6 insertions(+), 7 deletions(-)
--
Regards,
Laurent Pinchart