2019-03-17 01:59:58

by Emanuel Bennici

Subject: [PATCH 1/2] staging: vc04_services: Add spaces around Operators

Fix Check from the checkpatch.pl Script
`CHECK: spaces preferred around that`
in vchi.h

Signed-off-by: Emanuel Bennici <[email protected]>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 0b6fc0d31f4c..7b13cb04c119 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -41,14 +41,14 @@
Global defs
*****************************************************************************/

-#define VCHI_BULK_ROUND_UP(x) ((((unsigned long)(x))+VCHI_BULK_ALIGN-1) & ~(VCHI_BULK_ALIGN-1))
-#define VCHI_BULK_ROUND_DOWN(x) (((unsigned long)(x)) & ~(VCHI_BULK_ALIGN-1))
-#define VCHI_BULK_ALIGN_NBYTES(x) (VCHI_BULK_ALIGNED(x) ? 0 : (VCHI_BULK_ALIGN - ((unsigned long)(x) & (VCHI_BULK_ALIGN-1))))
+#define VCHI_BULK_ROUND_UP(x) ((((unsigned long)(x)) + VCHI_BULK_ALIGN - 1) & ~(VCHI_BULK_ALIGN - 1))
+#define VCHI_BULK_ROUND_DOWN(x) (((unsigned long)(x)) & ~(VCHI_BULK_ALIGN - 1))
+#define VCHI_BULK_ALIGN_NBYTES(x) (VCHI_BULK_ALIGNED(x) ? 0 : (VCHI_BULK_ALIGN - ((unsigned long)(x) & (VCHI_BULK_ALIGN - 1))))

#ifdef USE_VCHIQ_ARM
#define VCHI_BULK_ALIGNED(x) 1
#else
-#define VCHI_BULK_ALIGNED(x) (((unsigned long)(x) & (VCHI_BULK_ALIGN-1)) == 0)
+#define VCHI_BULK_ALIGNED(x) (((unsigned long)(x) & (VCHI_BULK_ALIGN - 1)) == 0)
#endif

struct vchi_version {
@@ -134,8 +134,8 @@ extern int32_t vchi_service_release(const VCHI_SERVICE_HANDLE_T handle);

// Routine to set a control option for a named service
extern int32_t vchi_service_set_option(const VCHI_SERVICE_HANDLE_T handle,
- VCHI_SERVICE_OPTION_T option,
- int value);
+ VCHI_SERVICE_OPTION_T option,
+ int value);

/* Routine to send a message from kernel memory across a service */
extern int
--
2.19.1

2019-03-17 11:32:16

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/2] staging: vc04_services: Add spaces around Operators

On Sun, Mar 17, 2019 at 02:59:05AM +0100, Emanuel Bennici wrote:
> Fix Check from the checkpatch.pl Script
> `CHECK: spaces preferred around that`
> in vchi.h

You also did something else here :(

Please fix up and resend.

thanks,

greg k-h