2019-03-17 02:02:15

by Emanuel Bennici

Subject: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration

Signed-off-by: Emanuel Bennici <[email protected]>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 7b13cb04c119..43eaf7703777 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -55,6 +55,7 @@ struct vchi_version {
uint32_t version;
uint32_t version_min;
};
+
#define VCHI_VERSION(v_) { v_, v_ }
#define VCHI_VERSION_EX(v_, m_) { v_, m_ }

--
2.19.1

2019-03-17 09:56:01

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration

On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> Signed-off-by: Emanuel Bennici <[email protected]>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> 1 file changed, 1 insertion(+)

I can not take patches without any changelog information, sorry.

2019-03-17 12:16:55

by Emanuel Bennici

Subject: Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration

Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
>> Signed-off-by: Emanuel Bennici <[email protected]>
>> ---
>> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
>> 1 file changed, 1 insertion(+)
> I can not take patches without any changelog information, sorry.

Add blank Line after declaration of struct vchi_version to fix checkpatch.pl
Check `CHECK: Please use a blank line after function/struct/union/enum
declarations`.

Signed-off-by: Emanuel Bennici <[email protected]>
---
 drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 7b13cb04c119..43eaf7703777 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -55,6 +55,7 @@ struct vchi_version {
     uint32_t version;
     uint32_t version_min;
 };
+
 #define VCHI_VERSION(v_) { v_, v_ }
 #define VCHI_VERSION_EX(v_, m_) { v_, m_ }
 
--
2.19.1

2019-03-17 12:40:44

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration

On Sun, Mar 17, 2019 at 01:14:26PM +0100, Emanuel Bennici wrote:
>
> Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> > On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> >> Signed-off-by: Emanuel Bennici <[email protected]>
> >> ---
> >> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> >> 1 file changed, 1 insertion(+)
> > I can not take patches without any changelog information, sorry.
>
> Add blank Line after declaration of struct vchi_version to fix checkpatch.pl
> Check `CHECK: Please use a blank line after function/struct/union/enum
> declarations`.
>
> Signed-off-by: Emanuel Bennici <[email protected]>
> ---
> ?drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> ?1 file changed, 1 insertion(+)
>

<snip>

Sorry, I can't take a patch that I have to hand-edit either.

Please fix up and resend the series correctly, with a proper version
information about what changed from the previous patch series as the
kernel process documentation explains.

thanks,

greg k-h