2019-03-18 16:41:16

by Koen Vandeputte

Subject: [PATCH] media: i2c: tda1997x: select V4L2_FWNODE

Building tda1997x fails now unless V4L2_FWNODE is selected:

drivers/media/i2c/tda1997x.o: in function `tda1997x_parse_dt'
undefined reference to `v4l2_fwnode_endpoint_parse'

While at it, also sort the selections alphabetically

Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")
Signed-off-by: Koen Vandeputte <[email protected]>
Cc: Akinobu Mita <[email protected]>
Cc: Bingbu Cao <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Jacopo Mondi <[email protected]>
Cc: Matt Ranostay <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Robin Leblon <[email protected]>
Cc: Rui Miguel Silva <[email protected]>
Cc: Sakari Ailus <[email protected]>
Cc: Tim Harvey <[email protected]>
Cc: [email protected]
Cc: [email protected] # v4.17+
---
drivers/media/i2c/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 4c936e129500..8b296ae7d68c 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -60,8 +60,9 @@ config VIDEO_TDA1997X
tristate "NXP TDA1997x HDMI receiver"
depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
depends on SND_SOC
- select SND_PCM
select HDMI
+ select SND_PCM
+ select V4L2_FWNODE
---help---
V4L2 subdevice driver for the NXP TDA1997x HDMI receivers.

--
2.17.1

2019-03-18 19:19:12

by Sakari Ailus

Subject: Re: [PATCH] media: i2c: tda1997x: select V4L2_FWNODE

On Mon, Mar 18, 2019 at 05:40:05PM +0100, Koen Vandeputte wrote:
> Building tda1997x fails now unless V4L2_FWNODE is selected:
>
> drivers/media/i2c/tda1997x.o: in function `tda1997x_parse_dt'
> undefined reference to `v4l2_fwnode_endpoint_parse'
>
> While at it, also sort the selections alphabetically
>
> Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")
> Signed-off-by: Koen Vandeputte <[email protected]>
> Cc: Akinobu Mita <[email protected]>
> Cc: Bingbu Cao <[email protected]>
> Cc: Hans Verkuil <[email protected]>
> Cc: Jacopo Mondi <[email protected]>
> Cc: Matt Ranostay <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Robin Leblon <[email protected]>
> Cc: Rui Miguel Silva <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Tim Harvey <[email protected]>
> Cc: [email protected]
> Cc: [email protected] # v4.17+

Acked-by: Sakari Ailus <[email protected]>

--
Sakari Ailus
[email protected]