2019-03-19 10:28:13

by Maxime Jourdan

Subject: [PATCH] clk: meson-gxbb: round the vdec dividers to closest

We want the video decoder clocks to always round to closest. While the
muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.

Fix this by adding the flag to the two vdec dividers.

Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
Signed-off-by: Maxime Jourdan <[email protected]>
---
drivers/clk/meson/gxbb.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index 04df2e208ed6..29ffb4fde714 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
.offset = HHI_VDEC_CLK_CNTL,
.shift = 0,
.width = 7,
+ .flags = CLK_DIVIDER_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
.name = "vdec_1_div",
@@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
.offset = HHI_VDEC2_CLK_CNTL,
.shift = 16,
.width = 7,
+ .flags = CLK_DIVIDER_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
.name = "vdec_hevc_div",
--
2.21.0

2019-03-19 16:35:17

by Neil Armstrong

Subject: Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest

On 19/03/2019 11:25, Maxime Jourdan wrote:
> We want the video decoder clocks to always round to closest. While the
> muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
> CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.
>
> Fix this by adding the flag to the two vdec dividers.
>
> Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
> Signed-off-by: Maxime Jourdan <[email protected]>
> ---
> drivers/clk/meson/gxbb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 04df2e208ed6..29ffb4fde714 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
> .offset = HHI_VDEC_CLK_CNTL,
> .shift = 0,
> .width = 7,
> + .flags = CLK_DIVIDER_ROUND_CLOSEST,
> },
> .hw.init = &(struct clk_init_data){
> .name = "vdec_1_div",
> @@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
> .offset = HHI_VDEC2_CLK_CNTL,
> .shift = 16,
> .width = 7,
> + .flags = CLK_DIVIDER_ROUND_CLOSEST,
> },
> .hw.init = &(struct clk_init_data){
> .name = "vdec_hevc_div",
>

Acked-by: Neil Armstrong <[email protected]>

Will apply to fixes/drivers for 5.1