2019-03-21 15:10:56

by Yue Haibing

Subject: [PATCH -next] pinctrl: artpec6: Make two functions static

From: YueHaibing <[email protected]>

Fix sparse warnings:

drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
symbol 'artpec6_pmx_enable' was not declared. Should it be static?
drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
symbol 'artpec6_pmx_disable' was not declared. Should it be static?

Signed-off-by: YueHaibing <[email protected]>
---
drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
index d89dc43..e836850 100644
--- a/drivers/pinctrl/pinctrl-artpec6.c
+++ b/drivers/pinctrl/pinctrl-artpec6.c
@@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
}
}

-int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
- unsigned int group)
+static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
+ unsigned int function,
+ unsigned int group)
{
struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);

@@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
return 0;
}

-void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
- unsigned int group)
+static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
+ unsigned int function,
+ unsigned int group)
{
struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);

--
2.7.0

2019-03-21 16:02:52

by Jesper Nilsson

Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static

On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Jesper Nilsson <[email protected]>

> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

2019-04-04 15:27:53

by Linus Walleij

Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static

On Thu, Mar 21, 2019 at 10:09 PM Yue Haibing <[email protected]> wrote:

> From: YueHaibing <[email protected]>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>

Patch applied with the ACKs.

Yours,
Linus Walleij

2019-04-08 18:51:45

by Nathan Chancellor

Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static

On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)

On arm32 allyesconfig:

drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
'artpec6_pmx_disable' [-Werror,-Wunused-function]

This is the second time you've introduced an unused function warning by
making a function static[1], could you please be a little more vigilant
in your clean ups in the future?

[1]: https://lore.kernel.org/lkml/[email protected]/

Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
send a patch doing so if that's the right course of action.

Thanks,
Nathan

> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0
>
>

2019-04-09 01:37:01

by Yue Haibing

Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static

On 2019/4/9 2:01, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
>> From: YueHaibing <[email protected]>
>>
>> Fix sparse warnings:
>>
>> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
>> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
>> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
>> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <[email protected]>
>> ---
>> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
>> index d89dc43..e836850 100644
>> --- a/drivers/pinctrl/pinctrl-artpec6.c
>> +++ b/drivers/pinctrl/pinctrl-artpec6.c
>> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
>> }
>> }
>>
>> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
>> - unsigned int group)
>> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
>> + unsigned int function,
>> + unsigned int group)
>> {
>> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>>
>> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
>> return 0;
>> }
>>
>> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
>> - unsigned int group)
>> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
>> + unsigned int function,
>> + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?

Sorry for this.

>
> [1]: https://lore.kernel.org/lkml/[email protected]/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.
>
> Thanks,
> Nathan
>
>> {
>> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>>
>> --
>> 2.7.0
>>
>>
>
> .
>

2019-04-09 06:58:52

by Jesper Nilsson

Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static

On Mon, Apr 08, 2019 at 11:01:10AM -0700, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> > From: YueHaibing <[email protected]>
> > -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> > - unsigned int group)
> > +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> > + unsigned int function,
> > + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?
>
> [1]: https://lore.kernel.org/lkml/[email protected]/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.

Yes, that function is unused and can be dropped.

> Thanks,
> Nathan

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]