2019-03-16 08:26:33

by Shenghui Wang

[permalink] [raw]
Subject: [PATCH] sbitmap: trivial - update comment for sbitmap_deferred_clear_bit

"sbitmap_batch_clear" should be "sbitmap_deferred_clear"

Signed-off-by: Shenghui Wang <[email protected]>
---
include/linux/sbitmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h
index 14d558146aea..20f3e3f029b9 100644
--- a/include/linux/sbitmap.h
+++ b/include/linux/sbitmap.h
@@ -330,7 +330,7 @@ static inline void sbitmap_clear_bit(struct sbitmap *sb, unsigned int bitnr)
/*
* This one is special, since it doesn't actually clear the bit, rather it
* sets the corresponding bit in the ->cleared mask instead. Paired with
- * the caller doing sbitmap_batch_clear() if a given index is full, which
+ * the caller doing sbitmap_deferred_clear() if a given index is full, which
* will clear the previously freed entries in the corresponding ->word.
*/
static inline void sbitmap_deferred_clear_bit(struct sbitmap *sb, unsigned int bitnr)
--
2.20.1





2019-03-21 22:15:08

by Omar Sandoval

[permalink] [raw]
Subject: Re: [PATCH] sbitmap: trivial - update comment for sbitmap_deferred_clear_bit

On Sat, Mar 16, 2019 at 04:24:37PM +0800, Shenghui Wang wrote:
> "sbitmap_batch_clear" should be "sbitmap_deferred_clear"

Acked-by: Omar Sandoval <[email protected]>

> Signed-off-by: Shenghui Wang <[email protected]>
> ---
> include/linux/sbitmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h
> index 14d558146aea..20f3e3f029b9 100644
> --- a/include/linux/sbitmap.h
> +++ b/include/linux/sbitmap.h
> @@ -330,7 +330,7 @@ static inline void sbitmap_clear_bit(struct sbitmap *sb, unsigned int bitnr)
> /*
> * This one is special, since it doesn't actually clear the bit, rather it
> * sets the corresponding bit in the ->cleared mask instead. Paired with
> - * the caller doing sbitmap_batch_clear() if a given index is full, which
> + * the caller doing sbitmap_deferred_clear() if a given index is full, which
> * will clear the previously freed entries in the corresponding ->word.
> */
> static inline void sbitmap_deferred_clear_bit(struct sbitmap *sb, unsigned int bitnr)
> --
> 2.20.1
>
>
>

2019-03-22 17:02:14

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] sbitmap: trivial - update comment for sbitmap_deferred_clear_bit

On 3/16/19 2:24 AM, Shenghui Wang wrote:
> "sbitmap_batch_clear" should be "sbitmap_deferred_clear"

Applied, thanks.

--
Jens Axboe