2019-03-22 03:03:40

by Hariprasad Kelam

Subject: [PATCH] tty: serial_core: Spelling correction

fix spelling mistake "overriden" -> "overridden"
This fix resolves warning reported by checkpatch tool

Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/tty/serial/serial_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 351843f..69f4871 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
}

uart_change_speed(tty, state, old_termios);
- /* reload cflag from termios; port driver may have overriden flags */
+ /* reload cflag from termios; port driver may have overridden flags */
cflag = tty->termios.c_cflag;

/* Handle transition to B0 status */
--
2.7.4

2019-03-22 03:30:02

by Gustavo A. R. Silva

Subject: Re: [PATCH] tty: serial_core: Spelling correction

On 3/21/19 10:01 PM, Hariprasad Kelam wrote:
> fix spelling mistake "overriden" -> "overridden"
> This fix resolves warning reported by checkpatch tool
>

Whenever you receive feedback on a patch, you need to version
the patches that you re-send. Also, you should mention what has
changed, so people know what to review.

I encourage you take a look at this:

https://kernelnewbies.org/Outreachyfirstpatch

Thanks
--
Gustavo

"If you receive feedback on a patch, and were asked to update the patch,
you need to version the patches that you re-send. A new version number
lets reviewers know you made changes to the patch, and they should review
it again."

> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 351843f..69f4871 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
> }
>
> uart_change_speed(tty, state, old_termios);
> - /* reload cflag from termios; port driver may have overriden flags */
> + /* reload cflag from termios; port driver may have overridden flags */
> cflag = tty->termios.c_cflag;
>
> /* Handle transition to B0 status */
>

2019-03-27 18:28:05

by Greg Kroah-Hartman

Subject: Re: [PATCH] tty: serial_core: Spelling correction

On Fri, Mar 22, 2019 at 08:31:59AM +0530, Hariprasad Kelam wrote:
> fix spelling mistake "overriden" -> "overridden"
> This fix resolves warning reported by checkpatch tool
>
> Signed-off-by: Hariprasad Kelam <[email protected]>
> ---
> drivers/tty/serial/serial_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

You sent 3 patches with the same subject, and so I have no idea which
one is the "latest" one.

Please fix up and resend with the proper version information as the
documentation asks you to.

thanks,

greg k-h