2019-03-20 20:59:33

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the ntb tree

Hi all,

In commit

f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")

Fixes tag

Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")

has these problem(s):

- Target SHA1 does not exist

Did you mean:

c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-03-20 21:02:18

by Logan Gunthorpe

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the ntb tree



On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
>
> Fixes tag
>
> Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Did you mean:
>
> c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")

My fault. I sent the fix patch with the fixes tag before the original
patch was merged upstream expecting them to be squashed. c59666bb32b9 is
the correct hash in upstream now.

Logan


2019-03-21 19:54:54

by Jon Mason

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the ntb tree

On Wed, Mar 20, 2019 at 5:00 PM Logan Gunthorpe <[email protected]> wrote:
>
>
>
> On 2019-03-20 2:58 p.m., Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is initaliazed")
> >
> > Fixes tag
> >
> > Fixes: c27ccb899219 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Did you mean:
> >
> > c59666bb32b9 ("NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA")
>
> My fault. I sent the fix patch with the fixes tag before the original
> patch was merged upstream expecting them to be squashed. c59666bb32b9 is
> the correct hash in upstream now.

I've corrected the patch in my git branches and repushed.

Is there an existing set of tools/scripts I should run to prevent
things like this from happening?

Thanks,
Jon

>
> Logan
>

2019-03-21 20:30:22

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the ntb tree

Hi Jon,

On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason <[email protected]> wrote:
>
> Is there an existing set of tools/scripts I should run to prevent
> things like this from happening?

I have attached the script I run over all new commits submitted for
linux-next.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (309.00 B)
 check_fixes (4.24 kB)
 (No filename) (499.00 B)
OpenPGP digital signature Download all attachments

2019-03-22 15:36:36

by Jon Mason

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the ntb tree

On Thu, Mar 21, 2019 at 4:28 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi Jon,
>
> On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason <[email protected]> wrote:
> >
> > Is there an existing set of tools/scripts I should run to prevent
> > things like this from happening?
>
> I have attached the script I run over all new commits submitted for
> linux-next.

Fantastic! I'll add a variation of this to my git tree and hopefully
prevent any future issues.

Thanks,
Jon

>
> --
> Cheers,
> Stephen Rothwell