2019-03-11 11:06:23

by Rouven Czerwinski

[permalink] [raw]
Subject: [PATCH] hwrng: omap - Set default quality

Newer combinations of the glibc, kernel and openssh can result in long initial
startup times on OMAP devices:

[ 6.671425] systemd-rc-once[102]: Creating ED25519 key; this may take some time ...
[ 142.652491] systemd-rc-once[102]: Creating ED25519 key; done.

due to the blocking getrandom(2) system call:

[ 142.610335] random: crng init done

Set the quality level for the omap hwrng driver allowing the kernel to use the
hwrng as an entropy source at boot.

Signed-off-by: Rouven Czerwinski <[email protected]>
---
drivers/char/hw_random/omap-rng.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
index b65ff6962899..e9b6ac61fb7f 100644
--- a/drivers/char/hw_random/omap-rng.c
+++ b/drivers/char/hw_random/omap-rng.c
@@ -443,6 +443,7 @@ static int omap_rng_probe(struct platform_device *pdev)
priv->rng.read = omap_rng_do_read;
priv->rng.init = omap_rng_init;
priv->rng.cleanup = omap_rng_cleanup;
+ priv->rng.quality = 900;

priv->rng.priv = (unsigned long)priv;
platform_set_drvdata(pdev, priv);
--
2.21.0



2019-03-22 13:05:05

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] hwrng: omap - Set default quality

On Mon, Mar 11, 2019 at 11:58:57AM +0100, Rouven Czerwinski wrote:
> Newer combinations of the glibc, kernel and openssh can result in long initial
> startup times on OMAP devices:
>
> [ 6.671425] systemd-rc-once[102]: Creating ED25519 key; this may take some time ...
> [ 142.652491] systemd-rc-once[102]: Creating ED25519 key; done.
>
> due to the blocking getrandom(2) system call:
>
> [ 142.610335] random: crng init done
>
> Set the quality level for the omap hwrng driver allowing the kernel to use the
> hwrng as an entropy source at boot.
>
> Signed-off-by: Rouven Czerwinski <[email protected]>
> ---
> drivers/char/hw_random/omap-rng.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt