2019-03-25 17:59:41

by Liviu Dudau

Subject: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled

We don't call this function if CONFIG_DEBUG_FS is not defined, but we
should not be compiling it either, as the declaration of the debugfs
core functions is not included.

Reported by the kbuild test robot.

Signed-off-by: Liviu Dudau <[email protected]>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index b420c6205d6bf..24548b87e1827 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
.release = single_release,
};

+#ifdef CONFIG_DEBUG_FS
static void komeda_debugfs_init(struct komeda_dev *mdev)
{
if (!debugfs_initialized())
@@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
debugfs_create_file("register", 0444, mdev->debugfs_root,
mdev, &komeda_register_fops);
}
+#endif

static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
{
--
2.21.0

2019-03-26 11:09:40

by James Qian Wang

Subject: Re: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled

On Mon, Mar 25, 2019 at 05:01:14PM +0000, Liviu Dudau wrote:
> We don't call this function if CONFIG_DEBUG_FS is not defined, but we
> should not be compiling it either, as the declaration of the debugfs
> core functions is not included.
>
> Reported by the kbuild test robot.
>
> Signed-off-by: Liviu Dudau <[email protected]>

Reviewed-by: James Qian Wang (Arm Technology China) <[email protected]>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index b420c6205d6bf..24548b87e1827 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
> .release = single_release,
> };
>
> +#ifdef CONFIG_DEBUG_FS
> static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> if (!debugfs_initialized())
> @@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> debugfs_create_file("register", 0444, mdev->debugfs_root,
> mdev, &komeda_register_fops);
> }
> +#endif
>
> static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> {
> --
> 2.21.0