2019-03-29 14:58:38

by Eugeniy Paltsev

Subject: [PATCH] trivial: MAINTAINERS: fix bad file pattern

Fix bad file pattern in MAINTAINERS section 'SYNOPSYS DESIGNWARE
AXI DMAC DRIVER'

Reported-by: Joe Perches <[email protected]>
Signed-off-by: Eugeniy Paltsev <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..30f5156336ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14987,7 +14987,7 @@ F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
SYNOPSYS DESIGNWARE AXI DMAC DRIVER
M: Eugeniy Paltsev <[email protected]>
S: Maintained
-F: drivers/dma/dwi-axi-dmac/
+F: drivers/dma/dwi-axi-dmac/*
F: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt

SYNOPSYS DESIGNWARE DMAC DRIVER
--
2.14.5

2019-03-29 15:20:01

by Joe Perches

Subject: Re: [PATCH] trivial: MAINTAINERS: fix bad file pattern

On Fri, 2019-03-29 at 17:57 +0300, Eugeniy Paltsev wrote:
> Fix bad file pattern in MAINTAINERS section 'SYNOPSYS DESIGNWARE
> AXI DMAC DRIVER'

NAK

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -14987,7 +14987,7 @@ F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
> SYNOPSYS DESIGNWARE AXI DMAC DRIVER
> M: Eugeniy Paltsev <[email protected]>
> S: Maintained
> -F: drivers/dma/dwi-axi-dmac/
> +F: drivers/dma/dwi-axi-dmac/*

This is not correct.

The original patch added these files:

drivers/dma/dw-axi-dmac/Makefile | 1 +
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1008 ++++++++++++++++++++++++
drivers/dma/dw-axi-dmac/dw-axi-dmac.h | 334 ++++++++

The pattern should not be dwi- but dw-

F: drivers/dma/dw-axi-dmac/

(no i after dw)

Also the patch subject and commit description should reference the
MAINTAINERS section.

So your patch should be something like
---
Subject: [PATCH] MAINTAINERS: Fix bad file pattern in SYNOPSYS DESIGNWARE AXI DMAC DRIVER

commit 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")
added an incorrect file pattern. Fix it.

Signed-off-by: <you>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..30f5156336ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14987,7 +14987,7 @@ F: Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
SYNOPSYS DESIGNWARE AXI DMAC DRIVER
M: Eugeniy Paltsev <[email protected]>
S: Maintained
-F: drivers/dma/dwi-axi-dmac/
+F: drivers/dma/dw-axi-dmac/
F: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt

SYNOPSYS DESIGNWARE DMAC DRIVER