2019-04-01 14:39:40

by Marcelo Schmitt

Subject: [PATCH 1/4] staging: iio: ad9832: organize includes

Organize includes to list them in lexicographic order.

Signed-off-by: Marcelo Schmitt <[email protected]>
---
drivers/staging/iio/frequency/ad9832.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index a3ce50427724..50a583020072 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -6,22 +6,24 @@
* Licensed under the GPL-2.
*/

+#include <asm/div64.h>
+
#include <linux/device.h>
+#include <linux/err.h>
#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/regulator/consumer.h>
#include <linux/slab.h>
-#include <linux/sysfs.h>
#include <linux/spi/spi.h>
-#include <linux/regulator/consumer.h>
-#include <linux/err.h>
-#include <linux/module.h>
-#include <asm/div64.h>
+#include <linux/sysfs.h>

#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
-#include "dds.h"

#include "ad9832.h"

+#include "dds.h"
+
/* Registers */

#define AD9832_FREQ0LL 0x0
--
2.20.1

2019-04-07 11:32:47

by Jonathan Cameron

Subject: Re: [PATCH 1/4] staging: iio: ad9832: organize includes

On Mon, 1 Apr 2019 11:37:10 -0300
Marcelo Schmitt <[email protected]> wrote:

> Organize includes to list them in lexicographic order.
>
> Signed-off-by: Marcelo Schmitt <[email protected]>
There are a few headers in there that I'd expect to be unnecessary once
cleanup on the driver is finished, but good to get them in a nice
order to start with.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
> drivers/staging/iio/frequency/ad9832.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index a3ce50427724..50a583020072 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -6,22 +6,24 @@
> * Licensed under the GPL-2.
> */
>
> +#include <asm/div64.h>
> +
> #include <linux/device.h>
> +#include <linux/err.h>
> #include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> -#include <linux/sysfs.h>
> #include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
> -#include <asm/div64.h>
> +#include <linux/sysfs.h>
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> -#include "dds.h"
>
> #include "ad9832.h"
>
> +#include "dds.h"
> +
> /* Registers */
>
> #define AD9832_FREQ0LL 0x0