2019-04-02 12:38:59

by Christina Quast

Subject: [PATCH] ALSA: doc: my_chip has no element ioport

chip->ioport is dereferenced in two places, but the struct is
defined as follows:

struct mychip {
struct snd_card *card;
struct pci_dev *pci;

unsigned long port;
int irq;
};

Signed-off-by: Christina Quast <[email protected]>
---
Documentation/sound/kernel-api/writing-an-alsa-driver.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
index 6b154dbb02cc..132f5eb9b530 100644
--- a/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
+++ b/Documentation/sound/kernel-api/writing-an-alsa-driver.rst
@@ -324,7 +324,7 @@ to details explained in the following section.
strcpy(card->driver, "My Chip");
strcpy(card->shortname, "My Own Chip 123");
sprintf(card->longname, "%s at 0x%lx irq %i",
- card->shortname, chip->ioport, chip->irq);
+ card->shortname, chip->port, chip->irq);

/* (5) */
.... /* implemented later */
@@ -437,7 +437,7 @@ Since each component can be properly freed, the single
strcpy(card->driver, "My Chip");
strcpy(card->shortname, "My Own Chip 123");
sprintf(card->longname, "%s at 0x%lx irq %i",
- card->shortname, chip->ioport, chip->irq);
+ card->shortname, chip->port, chip->irq);

The driver field holds the minimal ID string of the chip. This is used
by alsa-lib's configurator, so keep it simple but unique. Even the
--
2.20.1

2019-04-03 09:57:23

by Takashi Iwai

Subject: Re: [PATCH] ALSA: doc: my_chip has no element ioport

On Tue, 02 Apr 2019 14:16:48 +0200,
Christina Quast wrote:
>
> chip->ioport is dereferenced in two places, but the struct is
> defined as follows:
>
> struct mychip {
> struct snd_card *card;
> struct pci_dev *pci;
>
> unsigned long port;
> int irq;
> };
>
> Signed-off-by: Christina Quast <[email protected]>

Applied, thanks.


Takashi