Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: "sprd_platform_compr_ops" [sound/soc/sprd/sprd-pcm-dma.ko] undefined!
Caused by commit
cce1396936ef ("ASoC: sprd: Add Spreadtrum audio compress offload support")
I have used the sound-asoc tree from next-20190402 for today.
--
Cheers,
Stephen Rothwell
Hi,
On Wed, 3 Apr 2019 at 08:11, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "sprd_platform_compr_ops" [sound/soc/sprd/sprd-pcm-dma.ko] undefined!
>
> Caused by commit
>
> cce1396936ef ("ASoC: sprd: Add Spreadtrum audio compress offload support")
>
> I have used the sound-asoc tree from next-20190402 for today.
>
Thanks for pointing this out. I think I should fix the Makefile like this
snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
I will send out one incremental patch to fix this issue after my
business trip. Thanks.
--
Baolin Wang
Best Regards
On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote:
> snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
> obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
> I will send out one incremental patch to fix this issue after my
> business trip. Thanks.
We can't leave this broken in -next for that long, can you please post
the patch now if you've already got it?
On Wed, 3 Apr 2019 at 11:35, Mark Brown <[email protected]> wrote:
>
> On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote:
>
> > snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
>
> > obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
>
> > I will send out one incremental patch to fix this issue after my
> > business trip. Thanks.
>
> We can't leave this broken in -next for that long, can you please post
> the patch now if you've already got it?
OK, but I need some time to setup my environment to send this patch
and I'll try to fix this ASAP. Thanks.
--
Baolin Wang
Best Regards
On Wed, Apr 03, 2019 at 12:27:53PM +0800, Baolin Wang wrote:
> On Wed, 3 Apr 2019 at 11:35, Mark Brown <[email protected]> wrote:
> > We can't leave this broken in -next for that long, can you please post
> > the patch now if you've already got it?
> OK, but I need some time to setup my environment to send this patch
> and I'll try to fix this ASAP. Thanks.
Don't worry about it, I can do things directly - it was just if you had
the patch already it seemed better to use yours but if it's going to be
painful to set up a dev environment there's no need to worry.