2019-04-03 10:00:31

by Charles Keepax

[permalink] [raw]
Subject: [PATCH 1/2] mfd: cs47l35: Make DAC_AEC_CONTROL_2 readable

From: Richard Fitzgerald <[email protected]>

There is a second AEC loopback on cs47l35 so the registers for it should
be readable.

Signed-off-by: Richard Fitzgerald <[email protected]>
Signed-off-by: Charles Keepax <[email protected]>
---
drivers/mfd/cs47l35-tables.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/cs47l35-tables.c b/drivers/mfd/cs47l35-tables.c
index 604c9dd14df55..338b825127f13 100644
--- a/drivers/mfd/cs47l35-tables.c
+++ b/drivers/mfd/cs47l35-tables.c
@@ -178,6 +178,7 @@ static const struct reg_default cs47l35_reg_default[] = {
{ 0x00000448, 0x0a83 }, /* R1096 (0x448) - eDRE Enable */
{ 0x0000044a, 0x0000 }, /* R1098 (0x44a) - eDRE Manual */
{ 0x00000450, 0x0000 }, /* R1104 (0x450) - DAC AEC Control 1 */
+ { 0x00000451, 0x0000 }, /* R1105 (0x451) - DAC AEC Control 2 */
{ 0x00000458, 0x0000 }, /* R1112 (0x458) - Noise Gate Control */
{ 0x00000490, 0x0069 }, /* R1168 (0x490) - PDM SPK1 CTRL 1 */
{ 0x00000491, 0x0000 }, /* R1169 (0x491) - PDM SPK1 CTRL 2 */
@@ -970,6 +971,7 @@ static bool cs47l35_16bit_readable_register(struct device *dev,
case MADERA_EDRE_ENABLE:
case MADERA_EDRE_MANUAL:
case MADERA_DAC_AEC_CONTROL_1:
+ case MADERA_DAC_AEC_CONTROL_2:
case MADERA_NOISE_GATE_CONTROL:
case MADERA_PDM_SPK1_CTRL_1:
case MADERA_PDM_SPK1_CTRL_2:
--
2.11.0


2019-04-03 10:00:54

by Charles Keepax

[permalink] [raw]
Subject: [PATCH 2/2] mfd: cs47l90: Make DAC_AEC_CONTROL_2 readable

From: Ajit Pandey <[email protected]>

There is a second AEC loopback on cs47l90 so the registers for it should
be readable.

Signed-off-by: Ajit Pandey <[email protected]>
Signed-off-by: Charles Keepax <[email protected]>
---
drivers/mfd/cs47l90-tables.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/cs47l90-tables.c b/drivers/mfd/cs47l90-tables.c
index 77207d98f0cce..c040d3d7232a5 100644
--- a/drivers/mfd/cs47l90-tables.c
+++ b/drivers/mfd/cs47l90-tables.c
@@ -263,6 +263,7 @@ static const struct reg_default cs47l90_reg_default[] = {
{ 0x00000440, 0x003f }, /* R1088 (0x440) - DRE Enable */
{ 0x00000448, 0x003f }, /* R1096 (0x448) - eDRE Enable */
{ 0x00000450, 0x0000 }, /* R1104 (0x450) - DAC AEC Control 1 */
+ { 0x00000451, 0x0000 }, /* R1104 (0x450) - DAC AEC Control 2 */
{ 0x00000458, 0x0000 }, /* R1112 (0x458) - Noise Gate Control */
{ 0x00000490, 0x0069 }, /* R1168 (0x490) - PDM SPK1 CTRL 1 */
{ 0x00000491, 0x0000 }, /* R1169 (0x491) - PDM SPK1 CTRL 2 */
@@ -1692,6 +1693,7 @@ static bool cs47l90_16bit_readable_register(struct device *dev,
case MADERA_DRE_ENABLE:
case MADERA_EDRE_ENABLE:
case MADERA_DAC_AEC_CONTROL_1:
+ case MADERA_DAC_AEC_CONTROL_2:
case MADERA_NOISE_GATE_CONTROL:
case MADERA_PDM_SPK1_CTRL_1:
case MADERA_PDM_SPK1_CTRL_2:
--
2.11.0

2019-04-04 07:19:32

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 1/2] mfd: cs47l35: Make DAC_AEC_CONTROL_2 readable

On Wed, 03 Apr 2019, Charles Keepax wrote:

> From: Richard Fitzgerald <[email protected]>
>
> There is a second AEC loopback on cs47l35 so the registers for it should
> be readable.
>
> Signed-off-by: Richard Fitzgerald <[email protected]>
> Signed-off-by: Charles Keepax <[email protected]>
> ---
> drivers/mfd/cs47l35-tables.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2019-04-04 08:09:18

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 2/2] mfd: cs47l90: Make DAC_AEC_CONTROL_2 readable

On Wed, 03 Apr 2019, Charles Keepax wrote:

> From: Ajit Pandey <[email protected]>
>
> There is a second AEC loopback on cs47l90 so the registers for it should
> be readable.
>
> Signed-off-by: Ajit Pandey <[email protected]>
> Signed-off-by: Charles Keepax <[email protected]>
> ---
> drivers/mfd/cs47l90-tables.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog