2019-04-04 12:49:02

by Antti Keränen

Subject: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable

Do not use uninitialized variable 'port' when printing an error message

Signed-off-by: Antti Keränen <[email protected]>
---
drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
index 118302c122ee..aa3ae7777632 100644
--- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
+++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
@@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)

ret = of_address_to_resource(np, 0, &res);
if (ret) {
- dev_err(dev, "failed to get address resource(id-%d)\n", port);
+ dev_err(dev, "failed to get address resource\n");
return ret;
}

--
2.21.0

2019-04-04 12:57:05

by Sergio Paracuellos

Subject: Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable

On Thu, Apr 4, 2019 at 2:46 PM Antti Keränen <[email protected]> wrote:
>
> Do not use uninitialized variable 'port' when printing an error message
>
> Signed-off-by: Antti Keränen <[email protected]>
> ---
> drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> index 118302c122ee..aa3ae7777632 100644
> --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> @@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
>
> ret = of_address_to_resource(np, 0, &res);
> if (ret) {
> - dev_err(dev, "failed to get address resource(id-%d)\n", port);
> + dev_err(dev, "failed to get address resource\n");
> return ret;
> }

Reviewed-by: Sergio Paracuellos <[email protected]>

Thanks,
Sergio Paracuellos

>
> --
> 2.21.0
>