2019-04-07 09:05:47

by Axel Lin

Subject: [PATCH] regulator: bd718x7: Use rdev_get_id() to get regulator id

Use rdev_get_id() instead of directly access rdev->desc->id.
While at it also remove unneeded init for ramp_value variable.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/bd718x7-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c
index b2191be49670..fde4264da6ff 100644
--- a/drivers/regulator/bd718x7-regulator.c
+++ b/drivers/regulator/bd718x7-regulator.c
@@ -27,8 +27,8 @@
static int bd718xx_buck1234_set_ramp_delay(struct regulator_dev *rdev,
int ramp_delay)
{
- int id = rdev->desc->id;
- unsigned int ramp_value = BUCK_RAMPRATE_10P00MV;
+ int id = rdev_get_id(rdev);
+ unsigned int ramp_value;

dev_dbg(&rdev->dev, "Buck[%d] Set Ramp = %d\n", id + 1,
ramp_delay);
--
2.17.1

2019-04-08 10:43:34

by Matti Vaittinen

Subject: Re: [PATCH] regulator: bd718x7: Use rdev_get_id() to get regulator id

On Sun, Apr 07, 2019 at 05:03:02PM +0800, Axel Lin wrote:
> Use rdev_get_id() instead of directly access rdev->desc->id.
> While at it also remove unneeded init for ramp_value variable.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/bd718x7-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/bd718x7-regulator.c b/drivers/regulator/bd718x7-regulator.c
> index b2191be49670..fde4264da6ff 100644
> --- a/drivers/regulator/bd718x7-regulator.c
> +++ b/drivers/regulator/bd718x7-regulator.c
> @@ -27,8 +27,8 @@
> static int bd718xx_buck1234_set_ramp_delay(struct regulator_dev *rdev,
> int ramp_delay)
> {
> - int id = rdev->desc->id;
> - unsigned int ramp_value = BUCK_RAMPRATE_10P00MV;
> + int id = rdev_get_id(rdev);
> + unsigned int ramp_value;
>
> dev_dbg(&rdev->dev, "Buck[%d] Set Ramp = %d\n", id + 1,
> ramp_delay);
> --
> 2.17.1
>
Acked-by: Matti Vaittinen <[email protected]>